Bugzilla – Attachment 134208 Details for
Bug 30630
Checking in a waiting hold at another branch when HoldsAutoFill is enabled causes errors
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30630: Prevent crash on check-in if HoldsAutoFill is ON
Bug-30630-Prevent-crash-on-check-in-if-HoldsAutoFi.patch (text/plain), 1.55 KB, created by
David Nind
on 2022-04-28 09:21:19 UTC
(
hide
)
Description:
Bug 30630: Prevent crash on check-in if HoldsAutoFill is ON
Filename:
MIME Type:
Creator:
David Nind
Created:
2022-04-28 09:21:19 UTC
Size:
1.55 KB
patch
obsolete
>From 49cfbacc632a78121c66924c6675af58c7c24b57 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 28 Apr 2022 09:43:06 +0200 >Subject: [PATCH] Bug 30630: Prevent crash on check-in if HoldsAutoFill is ON > >RevertWaitingStatus has already removed the itemnumber from the hold, passing $itemnumber (from scanned item) should work, as it will reattach the hold to the item > >Test plan: >1 - Enable HoldsAutoFill >2 - Place a title level hold >3 - Check in an item and confirm hold >4 - Switch to another branch >5 - Checkin the item >Without this patch you got >Can't call method "biblionumber" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 1577. > at /kohadevbox/koha/C4/Reserves.pm line 1576 >With this patch applied the operation succeeds > >Signed-off-by: David Nind <david@davidnind.com> >--- > circ/returns.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/circ/returns.pl b/circ/returns.pl >index f98907187a..8a6f5fff2a 100755 >--- a/circ/returns.pl >+++ b/circ/returns.pl >@@ -474,7 +474,7 @@ if ( $messages->{'ResFound'} ) { > my $biblio = $item->biblio; > > my $diffBranchSend = !$branchCheck ? $reserve->{branchcode} : undef; >- ModReserveAffect( $reserve->{itemnumber}, $reserve->{borrowernumber}, $diffBranchSend, $reserve->{reserve_id}, $desk_id ); >+ ModReserveAffect( $itemnumber, $reserve->{borrowernumber}, $diffBranchSend, $reserve->{reserve_id}, $desk_id ); > my ( $messages, $nextreservinfo ) = GetOtherReserves($reserve->{itemnumber}); > > $template->param( >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30630
:
134203
|
134208
|
134218