Attachment 134265 Details for Bug 30644 – Bug 30644: (bug 29788 follow-up) Make Koha::Item->safe_to_delete use Koha::Result::Boolean

[patch] Bug 30644: (bug 29788 follow-up) Make Koha::Item->safe_to_delete use Koha::Result::Boolean

Bug-30644-bug-29788-follow-up-Make-KohaItem-safeto.patch (text/plain), 1.02 KB, created by Nick Clemens (kidclamp) on 2022-04-28 13:54:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2022-04-28 13:54:56 UTC

Size: 1.02 KB

patch

obsolete

>From d2ac4488c170df40f6f8b38764d373e80e7ebf69 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 28 Apr 2022 15:44:16 +0200
>Subject: [PATCH] Bug 30644: (bug 29788 follow-up) Make
> Koha::Item->safe_to_delete use Koha::Result::Boolean
>
>Fix item deletion
>
>Wrong if/else!
>
>Test plan:
>Delete an item
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> cataloguing/additem.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl
>index b7508db1a7..d1db1d15f9 100755
>--- a/cataloguing/additem.pl
>+++ b/cataloguing/additem.pl
>@@ -378,7 +378,7 @@ if ($op eq "additem") {
>     # check that there is no issue on this item before deletion.
>     my $item = Koha::Items->find($itemnumber);
>     my $deleted = $item->safe_delete;
>-    unless ( $deleted ) {
>+    if ( $deleted ) {
>         print $input->redirect("additem.pl?biblionumber=$biblionumber&frameworkcode=$frameworkcode&searchid=$searchid");
>         exit;
>     }
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30644: 134264 | 134265