Attachment 134446 Details for Bug 30658 – Bug 30658: (bug 29496 follow-up) CheckMandatorySubfields don't work properly with select field in serials-edit.tt for Supplemental issue

[patch] Bug 30658: (bug 29496 follow-up) CheckMandatorySubfields don't work properly with select field in serials-edit.tt for Supplemental issue

0001-Bug-30658-bug-29496-follow-up-CheckMandatorySubfield.patch (text/plain), 2.58 KB, created by Janusz Kaczmarek on 2022-05-01 22:22:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Janusz Kaczmarek

Created: 2022-05-01 22:22:01 UTC

Size: 2.58 KB

patch

obsolete

>From 3e6d0b88f30db34de377cf52df6242c236cb9eff Mon Sep 17 00:00:00 2001
>From: Janusz Kaczmarek <januszop@gmail.com>
>Date: Sun, 1 May 2022 23:59:09 +0200
>Subject: [PATCH] Bug 30658: (bug 29496 follow-up) CheckMandatorySubfields
> don't work properly with select field in serials-edit.tt for Supplemental
> issue
>
>CheckMandatorySubfields use the class "input_marceditor" but in file
>serials-edit.tt this class is not set for select input in Supplemental
>issue form. In consequence if a select field is set as mandatory, it is
>detected as missing even if it is filed and so you can't submit the form
>and receive the new supplemantal issue.
>
>Test plan:
>1- Create (or find) a subscription for a biblio record and select the
>   option "Create an item record when receiving this serial"
>2- Be sure to have at least one mandatory subfield that is filed with a
>   select input in the framework used by the biblio record. (ex: 952$a,
>   952$b or 952$c).
>3- From the subscription-detail page click on "Receive"
>4- In the lower part--Supplemental issue--fill the suppelemant details,
>   change the status to "Arrived" and fill the item form that appears.
>5- Click on "Save"
>6- Check that an error box appear with the message " Form not submitted
>   because of the following problem(s) 1 mandatory fields empty
>   (highlighted)" (the number can be different according to the number of
>   concerned subfields)
>7- Apply the patch
>8- Repeat step 3 to 5
>9- Check that no error appear and that your item has been created
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
>index d1b93145f4..881c857b2a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
>@@ -399,7 +399,7 @@ $(document).ready(function() {
>                     <label>[% iteminformatio.subfield | html %] - [% iteminformatio.marc_lib | $raw %]</label>
>                 [% END %]
>                 [% IF ( iteminformatio.marc_value.type == 'select' ) %]
>-                  <select name="field_value">
>+                  <select name="field_value" class="select2 input_marceditor">
>                   [% FOREACH value IN iteminformatio.marc_value.values %]
>                     [% IF ( value == iteminformatio.marc_value.default ) %]
>                       <option value="[% value | html %]" selected="selected">[% iteminformatio.marc_value.labels.$value | html %]</option>
>-- 
>2.30.2
>

Actions: View | Diff | Splinter Review

Attachments on bug 30658: 134446 | 136332 | 138450