Attachment 134579 Details for Bug 30167 – Bug 30167: (follow-up) Compare dt objects

[patch] Bug 30167: (follow-up) Compare dt objects

Bug-30167-follow-up-Compare-dt-objects.patch (text/plain), 2.04 KB, created by Nick Clemens (kidclamp) on 2022-05-04 11:38:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2022-05-04 11:38:54 UTC

Size: 2.04 KB

patch

obsolete

>From 56d0b2426817a5cd31b2af5621801e787cc59542 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 4 May 2022 11:38:08 +0000
>Subject: [PATCH] Bug 30167: (follow-up) Compare dt objects
>
>---
> t/db_dependent/Circulation.t | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t
>index 34b16f5644..74ce1ca53c 100755
>--- a/t/db_dependent/Circulation.t
>+++ b/t/db_dependent/Circulation.t
>@@ -800,7 +800,7 @@ subtest "CanBookBeRenewed tests" => sub {
>     is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
>     is( $error, 'auto_too_soon',
>         'Bug 14101: Cannot renew, renewal is automatic and premature, "No renewal before" = undef (returned code is auto_too_soon)' );
>-    is( $info->{soonest_renew_date} , $issue->date_due, "Due date is returned as earliest renewal date when error is 'auto_too_soon'" );
>+    is( $info->{soonest_renew_date} , dt_from_string($issue->date_due), "Due date is returned as earliest renewal date when error is 'auto_too_soon'" );
>     AddReserve(
>         {
>             branchcode       => $branch,
>@@ -822,7 +822,7 @@ subtest "CanBookBeRenewed tests" => sub {
>     ( $renewokay, $error, $info ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber, undef, 1 );
>     is( $renewokay, 0, 'Still should not be able to renew' );
>     is( $error, 'auto_too_soon', 'returned code is auto_too_soon, reserve not checked when checking for cron' );
>-    is( $info->{soonest_renew_date}, $issue->date_due, "Due date is returned as earliest renewal date when error is 'auto_too_soon'" );
>+    is( $info->{soonest_renew_date}, dt_from_string($issue->date_due), "Due date is returned as earliest renewal date when error is 'auto_too_soon'" );
>     ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber, 1 );
>     is( $renewokay, 0, 'Still should not be able to renew' );
>     is( $error, 'on_reserve', 'returned code is on_reserve, auto_too_soon limit is overridden' );
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30167: 131046 | 131047 | 134082 | 134083 | 134197 | 134198 | 134380 | 134454 | 134455 | 134456 | 134576 | 134577 | 134578 | 134579 | 135016