Bugzilla – Attachment 134611 Details for
Bug 30473
Convert suggestions page tabs to Bootstrap
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30473: Convert suggestions page tabs to Bootstrap
Bug-30473-Convert-suggestions-page-tabs-to-Bootstr.patch (text/plain), 45.99 KB, created by
Owen Leonard
on 2022-05-04 13:57:48 UTC
(
hide
)
Description:
Bug 30473: Convert suggestions page tabs to Bootstrap
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2022-05-04 13:57:48 UTC
Size:
45.99 KB
patch
obsolete
>From 86e2bef01520bb803bec56cbe6e8ebd1cc9af420 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 6 Apr 2022 15:35:47 +0000 >Subject: [PATCH] Bug 30473: Convert suggestions page tabs to Bootstrap > >This patch updates the suggestions page to use Bootstrap tabs >instead of jQueryUI. > >To test you should have multiple suggestions from different libraries, >different item types, and different statuses. > >Apply the patch and go to Suggestions. > >- Suggestions should initially be displayed in tabs by status. >- Confirm that the tabs look correct and work correctly. >- Test that tabs work correctly for each option in the "Organize by" > dropdown in the left-hand sidebar. > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../prog/en/modules/suggestion/suggestion.tt | 506 +++++++++--------- > 1 file changed, 255 insertions(+), 251 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index 584764bd5f..78da04cc78 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -686,10 +686,10 @@ > > [% UNLESS ( notabs ) %] > <div id="suggestiontabs" class="toptabs"> >- <ul class="ui-tabs-nav"> >+ <ul class="nav nav-tabs" role="tablist"> > [% FOREACH suggestion IN suggestions %] >- <li> >- <a href="#[% suggestion.suggestiontype | uri %]"> >+ <li role="presentation"> >+ <a href="#[% suggestion.suggestiontype | uri %]" aria-controls="[% suggestion.suggestiontype | uri %]" role="tab" data-toggle="tab"> > [% IF ( suggestion.suggestiontypelabel ) %] > [% IF (suggestion.suggestiontypelabel == "Pending") %]<span>Pending</span> > [% ELSIF (suggestion.suggestiontypelabel == "Accepted") %]<span>Accepted</span> >@@ -707,274 +707,277 @@ > <span>No name</span> > [% END %] > [% END %] >- ([% suggestion.suggestions_loop.size | html %])</a></li> >- >+ ([% suggestion.suggestions_loop.size | html %]) >+ </a> >+ </li> > [% END # /FOREACH suggestion %] > </ul> <!-- /.ui-tabs-nav --> >+ <div class="tab-content"> > [% END # /UNLESS notabs %] > >- [% FOREACH suggestion IN suggestions %] >- <div id="[% suggestion.suggestiontype | html %]"> >- <form class="update_suggestions" name="f" method="post" action="/cgi-bin/koha/suggestion/suggestion.pl#[% suggestion.suggestiontype| uri %]"> >+ [% FOREACH suggestion IN suggestions %] >+ <div id="[% suggestion.suggestiontype | html %]" role="tabpanel" class="tab-pane"> >+ <form class="update_suggestions" name="f" method="post" action="/cgi-bin/koha/suggestion/suggestion.pl#[% suggestion.suggestiontype| uri %]"> > >- [% IF ( suggestion.suggestions_loop ) %] >- <p> >- <a class="checkall" href="#">Check all</a> | <a class="uncheckall" href="#">Uncheck all</a> >- </p> >+ [% IF ( suggestion.suggestions_loop ) %] >+ <p> >+ <a class="checkall" href="#">Check all</a> | <a class="uncheckall" href="#">Uncheck all</a> >+ </p> > >- <table id="table_[% loop.count | html %]" class="sorted"> >- <thead> >- <tr> >- <th class="NoSort noExport"> </th> >- <th class="anti-the">Suggestion</th> >- <th>Suggested by</th> >- <th>Suggested on</th> >- <th>Managed by</th> >- <th>Managed on</th> >- <th>Last modification by</th> >- <th>Last modification on</th> >- <th>Last updated</th> >- <th>Library</th> >- <th>Fund</th> >- <th>Status</th> >- <th class="NoSort noExport"> </th> >- </tr> >- </thead> >- <tbody> >- [% FOREACH suggestions_loo IN suggestion.suggestions_loop %] >+ <table id="table_[% loop.count | html %]" class="sorted"> >+ <thead> > <tr> >- <td> >- <input type="checkbox" name="suggestionid" value="[% suggestions_loo.suggestionid | html %]" /> >- </td> >- <td> >- <a href="suggestion.pl?suggestionid=[% suggestions_loo.suggestionid | uri %]&op=show" title="suggestion" > >- [% suggestions_loo.title | html %][% IF ( suggestions_loo.author ) %], by [% suggestions_loo.author | html %][% END %] >- </a> >- <br /> >- [% IF ( suggestions_loo.copyrightdate ) %] >- © <span class="suggestion_copyrightdate">[% suggestions_loo.copyrightdate | html %]</span> >- [% END %] >- [% IF ( suggestions_loo.volumedesc ) %] >- ; <span class="suggestion_volume">Volume:<em>[% suggestions_loo.volumedesc | html %]</em></span> >- [% END %] >- [% IF ( suggestions_loo.isbn ) %] >- ; <span class="suggestion_isbn">ISBN: <em>[% suggestions_loo.isbn | html %]</em></span> >- [% END %] >- [% IF ( suggestions_loo.publishercode ) %] >- ; <span class="suggestion_publishercode">Published by [% suggestions_loo.publishercode | html %]</span> >- [% END %] >- [% IF ( suggestions_loo.publicationyear ) %] >- in <span class="suggestion_publicationyear"><em>[% suggestions_loo.publicationyear | html %]</em></span> >- [% END %] >- [% IF ( suggestions_loo.place ) %] >- in <span class="suggestion_place"><em>[% suggestions_loo.place | html %]</em></span> >- [% END %] >- [% IF ( suggestions_loo.collectiontitle ) %] >- ; <span class="suggestion_collectiontitle">[% suggestions_loo.collectiontitle | html %]</span> >- [% END %] >- [% IF ( suggestions_loo.itemtype ) %] >- ; <span class="suggestion_itype">[% AuthorisedValues.GetByCode( 'SUGGEST_FORMAT', suggestions_loo.itemtype, 0 ) | html %]</span> >- [% END %] >- <br /> >- [% IF ( suggestions_loo.note ) %] >- <div class="suggestion_note"><i class="fa fa-comment"></i> [% suggestions_loo.note | html %]</div> >- [% END %] >- [% IF suggestions_loo.archived %] >- <br /><i class="fa fa-archive"></i> Archived >- [% END %] >- </td> >- <td> >- <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% suggestions_loo.suggestedby | uri %]">[% suggestions_loo.surnamesuggestedby | html %][% IF ( suggestions_loo.firstnamesuggestedby ) %], [% suggestions_loo.firstnamesuggestedby | html %][% END %] [% IF (suggestions_loo.cardnumbersuggestedby ) %]([% suggestions_loo.cardnumbersuggestedby | html %])[% END %]</a> >- </td> >- <td data-order="[% suggestions_loo.suggesteddate | html %]"> >- [% IF ( suggestions_loo.suggesteddate ) %][% suggestions_loo.suggesteddate | $KohaDates %][% END %] >- </td> >- <td> >- <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% suggestions_loo.managedby | uri %]">[% suggestions_loo.surnamemanagedby | html %][% IF ( suggestions_loo.firstnamemanagedby ) %], [% suggestions_loo.firstnamemanagedby | html %][% END %]</a> >- </td> >- <td data-order="[% suggestions_loo.manageddate | html %]"> >- [% IF ( suggestions_loo.manageddate ) %][% suggestions_loo.manageddate | $KohaDates %][% END %] >- </td> >- <td> >- <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% suggestions_loo.lastmodificationby | uri %]">[% suggestions_loo.surnamelastmodificationby | html %][% IF ( suggestions_loo.firstnamelastmodificationby ) %], [% suggestions_loo.firstnamelastmodificationby | html %][% END %]</a> >- </td> >- <td data-order="[% suggestions_loo.lastmodificationdate | html %]"> >- [% IF ( suggestions_loo.lastmodificationdate ) %][% suggestions_loo.lastmodificationdate | $KohaDates %][% END %] >- </td> >- <td> >- [% suggestions_loo.date | $KohaDates %] >- </td> >- <td> >- [% Branches.GetName( suggestions_loo.branchcode ) | html %] >- </td> >- <td> >- [% suggestions_loo.budget_name | html %] >- </td> >- <td> >- [% IF ( suggestions_loo.ASKED ) %] >- Pending >- [% ELSIF ( suggestions_loo.ACCEPTED ) %] >- Accepted >- [% ELSIF ( suggestions_loo.ORDERED ) %] >- Ordered >- [% ELSIF ( suggestions_loo.REJECTED ) %] >- Rejected >- [% ELSIF ( suggestions_loo.CHECKED ) %] >- Checked >- [% ELSIF ( suggestions_loo.AVAILABLE ) %] >- Available >- [% ELSIF AuthorisedValues.GetByCode( 'SUGGEST_STATUS', suggestions_loo.STATUS ) %] >- [% AuthorisedValues.GetByCode( 'SUGGEST_STATUS', suggestions_loo.STATUS ) | html %] >- [% ELSE %] >- Status unknown >- [% END %] >- >- [% IF ( suggestions_loo.reason ) %] >- <br />([% suggestions_loo.reason | html %]) >- [% END %] >- </td> >- <td class="actions"> >- <div class="btn-group dropup"> >- <a class="btn btn-default btn-xs" role="button" href="suggestion.pl?suggestionid=[% suggestions_loo.suggestionid | html %]&op=edit"><i class="fa fa-pencil"></i> Edit</a><a class="btn btn-default btn-xs dropdown-toggle" id="more_actions_[% suggestions_loo.suggestionid | html %]" role="button" data-toggle="dropdown" href="#"><b class="caret"></b></a> >- <ul class="dropdown-menu pull-right" role="menu" aria-labelledby="more_actions_[% suggestions_loo.suggestionid | html %]"> >- <li><a class="deletesuggestion" href="suggestion.pl?op=delete&suggestionid=[% suggestions_loo.suggestionid | html %]"><i class="fa fa-trash"></i> Delete</a></li> >- [% UNLESS suggestions_loo.archived %] >- <li><a class="archivesuggestion" href="suggestion.pl?op=archive&suggestionid=[% suggestions_loo.suggestionid | html %]"><i class="fa fa-archive"></i> Archive</a></li> >- [% ELSE %] >- <li><a class="unarchivesuggestion" href="suggestion.pl?op=unarchive&suggestionid=[% suggestions_loo.suggestionid | html %]"><i class="fa fa-archive"></i> Unarchive</a></li> >- [% END %] >- </ul> >- </div> >- </td> >+ <th class="NoSort noExport"> </th> >+ <th class="anti-the">Suggestion</th> >+ <th>Suggested by</th> >+ <th>Suggested on</th> >+ <th>Managed by</th> >+ <th>Managed on</th> >+ <th>Last modification by</th> >+ <th>Last modification on</th> >+ <th>Last updated</th> >+ <th>Library</th> >+ <th>Fund</th> >+ <th>Status</th> >+ <th class="NoSort noExport"> </th> > </tr> >- [% END # /FOREACH suggestions_loo %] >- </tbody> >- </table> <!-- /#table_[% loop.count | html %] --> >- >- <div class="row"> >- <h2 style="padding-left:1em;">Change selected suggestions</h2> >- <div class="col-sm-4"> >- <fieldset> >- <div id="select-reason[% loop.index | html %]"> >- <label for="STATUSreason[% loop.index | html %]">Mark selected as: </label> >- <select name="STATUS" id="STATUSreason[% loop.index | html %]"> >- <option value=""> -- Choose a status --</option> >- >- [% IF (statusselected_ASKED ) %] >- <option value="ASKED" selected="selected">Pending</option> >- [% ELSE %] >- <option value="ASKED">Pending</option> >- [% END %] >- >- [% IF (statusselected_ACCEPTED ) %] >- <option value="ACCEPTED" selected="selected">Accepted</option> >- [% ELSE %] >- <option value="ACCEPTED">Accepted</option> >- [% END %] >+ </thead> >+ <tbody> >+ [% FOREACH suggestions_loo IN suggestion.suggestions_loop %] >+ <tr> >+ <td> >+ <input type="checkbox" name="suggestionid" value="[% suggestions_loo.suggestionid | html %]" /> >+ </td> >+ <td> >+ <a href="suggestion.pl?suggestionid=[% suggestions_loo.suggestionid | uri %]&op=show" title="suggestion" > >+ [% suggestions_loo.title | html %][% IF ( suggestions_loo.author ) %], by [% suggestions_loo.author | html %][% END %] >+ </a> >+ <br /> >+ [% IF ( suggestions_loo.copyrightdate ) %] >+ © <span class="suggestion_copyrightdate">[% suggestions_loo.copyrightdate | html %]</span> >+ [% END %] >+ [% IF ( suggestions_loo.volumedesc ) %] >+ ; <span class="suggestion_volume">Volume:<em>[% suggestions_loo.volumedesc | html %]</em></span> >+ [% END %] >+ [% IF ( suggestions_loo.isbn ) %] >+ ; <span class="suggestion_isbn">ISBN: <em>[% suggestions_loo.isbn | html %]</em></span> >+ [% END %] >+ [% IF ( suggestions_loo.publishercode ) %] >+ ; <span class="suggestion_publishercode">Published by [% suggestions_loo.publishercode | html %]</span> >+ [% END %] >+ [% IF ( suggestions_loo.publicationyear ) %] >+ in <span class="suggestion_publicationyear"><em>[% suggestions_loo.publicationyear | html %]</em></span> >+ [% END %] >+ [% IF ( suggestions_loo.place ) %] >+ in <span class="suggestion_place"><em>[% suggestions_loo.place | html %]</em></span> >+ [% END %] >+ [% IF ( suggestions_loo.collectiontitle ) %] >+ ; <span class="suggestion_collectiontitle">[% suggestions_loo.collectiontitle | html %]</span> >+ [% END %] >+ [% IF ( suggestions_loo.itemtype ) %] >+ ; <span class="suggestion_itype">[% AuthorisedValues.GetByCode( 'SUGGEST_FORMAT', suggestions_loo.itemtype, 0 ) | html %]</span> >+ [% END %] >+ <br /> >+ [% IF ( suggestions_loo.note ) %] >+ <div class="suggestion_note"><i class="fa fa-comment"></i> [% suggestions_loo.note | html %]</div> >+ [% END %] >+ [% IF suggestions_loo.archived %] >+ <br /><i class="fa fa-archive"></i> Archived >+ [% END %] >+ </td> >+ <td> >+ <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% suggestions_loo.suggestedby | uri %]">[% suggestions_loo.surnamesuggestedby | html %][% IF ( suggestions_loo.firstnamesuggestedby ) %], [% suggestions_loo.firstnamesuggestedby | html %][% END %] [% IF (suggestions_loo.cardnumbersuggestedby ) %]([% suggestions_loo.cardnumbersuggestedby | html %])[% END %]</a> >+ </td> >+ <td data-order="[% suggestions_loo.suggesteddate | html %]"> >+ [% IF ( suggestions_loo.suggesteddate ) %][% suggestions_loo.suggesteddate | $KohaDates %][% END %] >+ </td> >+ <td> >+ <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% suggestions_loo.managedby | uri %]">[% suggestions_loo.surnamemanagedby | html %][% IF ( suggestions_loo.firstnamemanagedby ) %], [% suggestions_loo.firstnamemanagedby | html %][% END %]</a> >+ </td> >+ <td data-order="[% suggestions_loo.manageddate | html %]"> >+ [% IF ( suggestions_loo.manageddate ) %][% suggestions_loo.manageddate | $KohaDates %][% END %] >+ </td> >+ <td> >+ <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% suggestions_loo.lastmodificationby | uri %]">[% suggestions_loo.surnamelastmodificationby | html %][% IF ( suggestions_loo.firstnamelastmodificationby ) %], [% suggestions_loo.firstnamelastmodificationby | html %][% END %]</a> >+ </td> >+ <td data-order="[% suggestions_loo.lastmodificationdate | html %]"> >+ [% IF ( suggestions_loo.lastmodificationdate ) %][% suggestions_loo.lastmodificationdate | $KohaDates %][% END %] >+ </td> >+ <td> >+ [% suggestions_loo.date | $KohaDates %] >+ </td> >+ <td> >+ [% Branches.GetName( suggestions_loo.branchcode ) | html %] >+ </td> >+ <td> >+ [% suggestions_loo.budget_name | html %] >+ </td> >+ <td> >+ [% IF ( suggestions_loo.ASKED ) %] >+ Pending >+ [% ELSIF ( suggestions_loo.ACCEPTED ) %] >+ Accepted >+ [% ELSIF ( suggestions_loo.ORDERED ) %] >+ Ordered >+ [% ELSIF ( suggestions_loo.REJECTED ) %] >+ Rejected >+ [% ELSIF ( suggestions_loo.CHECKED ) %] >+ Checked >+ [% ELSIF ( suggestions_loo.AVAILABLE ) %] >+ Available >+ [% ELSIF AuthorisedValues.GetByCode( 'SUGGEST_STATUS', suggestions_loo.STATUS ) %] >+ [% AuthorisedValues.GetByCode( 'SUGGEST_STATUS', suggestions_loo.STATUS ) | html %] >+ [% ELSE %] >+ Status unknown >+ [% END %] > >- [% IF (statusselected_CHECKED ) %] >- <option value="CHECKED" selected="selected">Checked</option> >- [% ELSE %] >- <option value="CHECKED">Checked</option> >- [% END %] >+ [% IF ( suggestions_loo.reason ) %] >+ <br />([% suggestions_loo.reason | html %]) >+ [% END %] >+ </td> >+ <td class="actions"> >+ <div class="btn-group dropup"> >+ <a class="btn btn-default btn-xs" role="button" href="suggestion.pl?suggestionid=[% suggestions_loo.suggestionid | html %]&op=edit"><i class="fa fa-pencil"></i> Edit</a><a class="btn btn-default btn-xs dropdown-toggle" id="more_actions_[% suggestions_loo.suggestionid | html %]" role="button" data-toggle="dropdown" href="#"><b class="caret"></b></a> >+ <ul class="dropdown-menu pull-right" role="menu" aria-labelledby="more_actions_[% suggestions_loo.suggestionid | html %]"> >+ <li><a class="deletesuggestion" href="suggestion.pl?op=delete&suggestionid=[% suggestions_loo.suggestionid | html %]"><i class="fa fa-trash"></i> Delete</a></li> >+ [% UNLESS suggestions_loo.archived %] >+ <li><a class="archivesuggestion" href="suggestion.pl?op=archive&suggestionid=[% suggestions_loo.suggestionid | html %]"><i class="fa fa-archive"></i> Archive</a></li> >+ [% ELSE %] >+ <li><a class="unarchivesuggestion" href="suggestion.pl?op=unarchive&suggestionid=[% suggestions_loo.suggestionid | html %]"><i class="fa fa-archive"></i> Unarchive</a></li> >+ [% END %] >+ </ul> >+ </div> >+ </td> >+ </tr> >+ [% END # /FOREACH suggestions_loo %] >+ </tbody> >+ </table> <!-- /#table_[% loop.count | html %] --> >+ >+ <div class="row"> >+ <h2 style="padding-left:1em;">Change selected suggestions</h2> >+ <div class="col-sm-4"> >+ <fieldset> >+ <div id="select-reason[% loop.index | html %]"> >+ <label for="STATUSreason[% loop.index | html %]">Mark selected as: </label> >+ <select name="STATUS" id="STATUSreason[% loop.index | html %]"> >+ <option value=""> -- Choose a status --</option> >+ >+ [% IF (statusselected_ASKED ) %] >+ <option value="ASKED" selected="selected">Pending</option> >+ [% ELSE %] >+ <option value="ASKED">Pending</option> >+ [% END %] > >- [% IF ( statusselected_REJECTED ) %] >- <option value="REJECTED" selected="selected">Rejected</option> >- [% ELSE %] >- <option value="REJECTED">Rejected</option> >- [% END %] >+ [% IF (statusselected_ACCEPTED ) %] >+ <option value="ACCEPTED" selected="selected">Accepted</option> >+ [% ELSE %] >+ <option value="ACCEPTED">Accepted</option> >+ [% END %] > >- [% IF ( statusselected_ORDERED ) %] >- <option value="ORDERED" selected="selected">Ordered</option> >- [% ELSE %] >- <option value="ORDERED">Ordered</option> >- [% END %] >+ [% IF (statusselected_CHECKED ) %] >+ <option value="CHECKED" selected="selected">Checked</option> >+ [% ELSE %] >+ <option value="CHECKED">Checked</option> >+ [% END %] > >- [% FOREACH s IN SuggestionStatuses %] >- <option value="[% s.authorised_value | html %]">[% s.lib | html %]</option> >- [% END %] >- </select> >+ [% IF ( statusselected_REJECTED ) %] >+ <option value="REJECTED" selected="selected">Rejected</option> >+ [% ELSE %] >+ <option value="REJECTED">Rejected</option> >+ [% END %] > >- <label for="choosereason[% loop.index | html %]">with this reason:</label> >- <select name="reason" id="choosereason[% loop.index | html %]"> >- <option value=""> -- Choose a reason -- </option> >- [% FOREACH reasonsloo IN suggestion.reasonsloop %] >- <option value="[% reasonsloo.lib | html %]">[% reasonsloo.lib | html %]</option> >- [% END %] >- <option value="other">Others...</option> >- </select> >+ [% IF ( statusselected_ORDERED ) %] >+ <option value="ORDERED" selected="selected">Ordered</option> >+ [% ELSE %] >+ <option value="ORDERED">Ordered</option> >+ [% END %] > >- <span class="other_reason"> >- <input type="text" size="31" name="other_reason" placeholder="please note your reason here..." /> >- <a href="#" class="cancel_note">Cancel</a> >- </span> >- </div> >+ [% FOREACH s IN SuggestionStatuses %] >+ <option value="[% s.authorised_value | html %]">[% s.lib | html %]</option> >+ [% END %] >+ </select> > >- <input type="hidden" name="branchcode" value="[% branchfilter | html %]" /> >- <input type="hidden" name="filter_archived" value="[% filter_archived | html %]" /> >- <fieldset class="action"> >- <button type="submit" class="btn btn-default btn-xs" value="update_status">Submit</button> >+ <label for="choosereason[% loop.index | html %]">with this reason:</label> >+ <select name="reason" id="choosereason[% loop.index | html %]"> >+ <option value=""> -- Choose a reason -- </option> >+ [% FOREACH reasonsloo IN suggestion.reasonsloop %] >+ <option value="[% reasonsloo.lib | html %]">[% reasonsloo.lib | html %]</option> >+ [% END %] >+ <option value="other">Others...</option> >+ </select> >+ >+ <span class="other_reason"> >+ <input type="text" size="31" name="other_reason" placeholder="please note your reason here..." /> >+ <a href="#" class="cancel_note">Cancel</a> >+ </span> >+ </div> >+ >+ <input type="hidden" name="branchcode" value="[% branchfilter | html %]" /> >+ <input type="hidden" name="filter_archived" value="[% filter_archived | html %]" /> >+ <fieldset class="action"> >+ <button type="submit" class="btn btn-default btn-xs" value="update_status">Submit</button> >+ </fieldset> > </fieldset> >- </fieldset> >- </div> <!-- /.col-sm-4 --> >- >- <div class="col-sm-4"> >- <fieldset> >- <label> >- Update item types with: >- [% PROCESS 'av-build-dropbox.inc' name="suggestion_itemtype", category="SUGGEST_FORMAT", size = 20 %] >- </label> >- <input type="hidden" name="branchcode" value="[% branchfilter | html %]" /> >- <input type="hidden" name="filter_archived" value="[% filter_archived | html %]" /> >- <fieldset class="action"> >- <button type="submit" class="btn btn-default btn-xs" value="update_itemtype">Submit</button> >+ </div> <!-- /.col-sm-4 --> >+ >+ <div class="col-sm-4"> >+ <fieldset> >+ <label> >+ Update item types with: >+ [% PROCESS 'av-build-dropbox.inc' name="suggestion_itemtype", category="SUGGEST_FORMAT", size = 20 %] >+ </label> >+ <input type="hidden" name="branchcode" value="[% branchfilter | html %]" /> >+ <input type="hidden" name="filter_archived" value="[% filter_archived | html %]" /> >+ <fieldset class="action"> >+ <button type="submit" class="btn btn-default btn-xs" value="update_itemtype">Submit</button> >+ </fieldset> > </fieldset> >- </fieldset> >- </div> <!-- /.col-sm-4 --> >- >- <div class="col-sm-2"> >- <fieldset> >- <span class="label">Update manager</span><br/> >- <a id="set_manager_[% loop.count | html %]" data-tab="[% loop.count | html %]" class="set_manager" href="#"><i class="fa fa-search"></i> Select manager</a> >- <span id="managedby_name[% loop.count | html %]"></span> >- <input type="hidden" name="suggestion_managedby" id="managedby[% loop.count | html %]" value="[% logged_in_user.borrowernumber | html %]" /> >- <input type="hidden" name="branchcode" value="[% branchfilter | html %]" /> >- <input type="hidden" name="filter_archived" value="[% filter_archived | html %]" /> >- <fieldset class="action"> >- <button type="submit" class="btn btn-default btn-xs" value="update_manager">Submit</button> >+ </div> <!-- /.col-sm-4 --> >+ >+ <div class="col-sm-2"> >+ <fieldset> >+ <span class="label">Update manager</span><br/> >+ <a id="set_manager_[% loop.count | html %]" data-tab="[% loop.count | html %]" class="set_manager" href="#"><i class="fa fa-search"></i> Select manager</a> >+ <span id="managedby_name[% loop.count | html %]"></span> >+ <input type="hidden" name="suggestion_managedby" id="managedby[% loop.count | html %]" value="[% logged_in_user.borrowernumber | html %]" /> >+ <input type="hidden" name="branchcode" value="[% branchfilter | html %]" /> >+ <input type="hidden" name="filter_archived" value="[% filter_archived | html %]" /> >+ <fieldset class="action"> >+ <button type="submit" class="btn btn-default btn-xs" value="update_manager">Submit</button> >+ </fieldset> > </fieldset> >- </fieldset> >- </div> <!-- /.col-sm-2 --> >- >- <div class="col-sm-2"> >- <fieldset> >- <span class="label">Delete selected</span> >- <input type="hidden" name="branchcode" value="[% branchfilter | html %]" /> >- <input type="hidden" name="filter_archived" value="[% filter_archived | html %]" /> >- <fieldset class="action"> >- <button type="submit" class="btn btn-default btn-xs" value="delete">Delete</button> >+ </div> <!-- /.col-sm-2 --> >+ >+ <div class="col-sm-2"> >+ <fieldset> >+ <span class="label">Delete selected</span> >+ <input type="hidden" name="branchcode" value="[% branchfilter | html %]" /> >+ <input type="hidden" name="filter_archived" value="[% filter_archived | html %]" /> >+ <fieldset class="action"> >+ <button type="submit" class="btn btn-default btn-xs" value="delete">Delete</button> >+ </fieldset> > </fieldset> >- </fieldset> >- </div> <!-- /.col-sm-2 --> >- <div class="col-sm-2"> >- <fieldset> >- <span class="label">Archive selected</span> >- <input type="hidden" name="branchcode" value="[% branchfilter | html %]" /> >- <input type="hidden" name="filter_archived" value="[% filter_archived | html %]" /> >- <fieldset class="action"> >- <button type="submit" class="btn btn-default btn-xs" value="archive">Archive</button> >+ </div> <!-- /.col-sm-2 --> >+ <div class="col-sm-2"> >+ <fieldset> >+ <span class="label">Archive selected</span> >+ <input type="hidden" name="branchcode" value="[% branchfilter | html %]" /> >+ <input type="hidden" name="filter_archived" value="[% filter_archived | html %]" /> >+ <fieldset class="action"> >+ <button type="submit" class="btn btn-default btn-xs" value="archive">Archive</button> >+ </fieldset> > </fieldset> >- </fieldset> >- </div> <!-- /.col-sm-2 --> >- </div> <!-- /.row --> >+ </div> <!-- /.col-sm-2 --> >+ </div> <!-- /.row --> > >- [% ELSE %] >- <strong>No results.</strong> >- [% END # /IF ( suggestion.suggestions_loop ) %] >- </form> <!-- /.update_suggestions --> >- </div> <!-- /#[% suggestion.suggestiontype | html %] --> >- [% END # /FOREACH suggestion %] >+ [% ELSE %] >+ <strong>No results.</strong> >+ [% END # /IF ( suggestion.suggestions_loop ) %] >+ </form> <!-- /.update_suggestions --> >+ </div> <!-- /#[% suggestion.suggestiontype | html %] --> >+ [% END # /FOREACH suggestion %] > [% UNLESS ( notabs ) %] >+ </div> <!-- /.tab-content --> > </div> <!-- /.notabs --> > [% END # /UNLESS notabs %] > [% END # /IF op == 'else' %] >@@ -1313,8 +1316,9 @@ > [% INCLUDE 'columns_settings.inc' %] > <script> > $(document).ready(function() { >- $('#suggestiontabs').tabs(); >- >+ if( $("#suggestiontabs .tab-pane.active").length < 1 ){ >+ $("#suggestiontabs a:first").tab("show"); >+ } > table_settings = [% TablesSettings.GetTableSettings( 'acqui', 'suggestions', 'suggestions', 'json' ) | $raw %] > [% FOREACH suggestion IN suggestions %] > [% IF ( suggestion.suggestions_loop ) %] >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30473
:
133044
|
133182
|
133484
| 134611