Attachment 134618 Details for Bug 30600 – Bug 30600: Fix recall reasons for branch transfers

[patch] Bug 30600: Fix recall reasons for branch transfers

Bug-30600-Fix-recall-reasons-for-branch-transfers.patch (text/plain), 4.28 KB, created by Fridolin Somers on 2022-05-04 20:09:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fridolin Somers

Created: 2022-05-04 20:09:49 UTC

Size: 4.28 KB

patch

obsolete

>From 3253c4aa5cd445112ec44e5f0af11cff7eb85051 Mon Sep 17 00:00:00 2001
>From: Aleisha Amohia <aleishaamohia@hotmail.com>
>Date: Wed, 27 Apr 2022 02:41:12 +0000
>Subject: [PATCH] Bug 30600: Fix recall reasons for branch transfers
>
>When a recall triggers a branch transfer, the reason for the transfer is
>'Recall'.
>
>When a transfer is cancelled that was triggered by a recall, depending
>on where it is cancelled, will use the 'Manual' or 'CancelRecall'
>cancellation reasons.
>
>This patch ensures branchtransfers.cancellation_reason adds 'CancelRecall',
>and branchtransfers.reason adds 'Recall' as options.
>
>Sponsored-by: Catalyst IT
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> installer/data/mysql/db_revs/211200018.pl | 10 ++++++++--
> installer/data/mysql/kohastructure.sql    |  4 ++--
> 2 files changed, 10 insertions(+), 4 deletions(-)
>
>diff --git a/installer/data/mysql/db_revs/211200018.pl b/installer/data/mysql/db_revs/211200018.pl
>index fac13045eb..65d06c4cf1 100755
>--- a/installer/data/mysql/db_revs/211200018.pl
>+++ b/installer/data/mysql/db_revs/211200018.pl
>@@ -88,10 +88,16 @@ Notes: <<recalls.recallnotes>>', 'print')
>                 INSERT IGNORE INTO permissions (module_bit, code, description) VALUES (27, 'manage_recalls', 'Manage recalls for patrons')
>             });
> 
>-            # Add Recall and CancelReserve ENUM options to branchtransfers.reason
>+            # Add Recall ENUM option to branchtransfers.reason
>             $dbh->do(q{
>                 ALTER TABLE branchtransfers MODIFY COLUMN reason
>-                ENUM('Manual', 'StockrotationAdvance', 'StockrotationRepatriation', 'ReturnToHome', 'ReturnToHolding', 'RotatingCollection', 'Reserve', 'LostReserve', 'CancelReserve', 'Recall', 'CancelRecall')
>+                ENUM('Manual', 'StockrotationAdvance', 'StockrotationRepatriation', 'ReturnToHome', 'ReturnToHolding', 'RotatingCollection', 'Reserve', 'LostReserve', 'CancelReserve', 'TransferCancellation', 'Recall')
>+            });
>+
>+            # Add CancelRecall ENUM option to branchtransfers.cancellation_reason
>+            $dbh->do(q{
>+                ALTER TABLE branchtransfers MODIFY COLUMN cancellation_reason
>+                ENUM('Manual', 'StockrotationAdvance', 'StockrotationRepatriation', 'ReturnToHome', 'ReturnToHolding', 'RotatingCollection', 'Reserve', 'LostReserve', 'CancelReserve', 'ItemLost', 'WrongTransfer', 'CancelRecall')
>             });
> 
>         }
>diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql
>index 3afb0455cc..80d38132c8 100644
>--- a/installer/data/mysql/kohastructure.sql
>+++ b/installer/data/mysql/kohastructure.sql
>@@ -1564,8 +1564,8 @@ CREATE TABLE `branchtransfers` (
>   `datecancelled` datetime DEFAULT NULL COMMENT 'the date the transfer was cancelled',
>   `tobranch` varchar(10) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT '' COMMENT 'the branch the transfer was going to',
>   `comments` longtext COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'any comments related to the transfer',
>-  `reason` enum('Manual','StockrotationAdvance','StockrotationRepatriation','ReturnToHome','ReturnToHolding','RotatingCollection','Reserve','LostReserve','CancelReserve','TransferCancellation','Recall','CancelRecall') COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'what triggered the transfer',
>-  `cancellation_reason` enum('Manual','StockrotationAdvance','StockrotationRepatriation','ReturnToHome','ReturnToHolding','RotatingCollection','Reserve','LostReserve','CancelReserve','ItemLost', 'WrongTransfer','Recall','CancelRecall') COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'what triggered the transfer cancellation',
>+  `reason` enum('Manual','StockrotationAdvance','StockrotationRepatriation','ReturnToHome','ReturnToHolding','RotatingCollection','Reserve','LostReserve','CancelReserve','TransferCancellation','Recall') COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'what triggered the transfer',
>+  `cancellation_reason` enum('Manual','StockrotationAdvance','StockrotationRepatriation','ReturnToHome','ReturnToHolding','RotatingCollection','Reserve','LostReserve','CancelReserve','ItemLost','WrongTransfer','CancelRecall') COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'what triggered the transfer cancellation',
>   PRIMARY KEY (`branchtransfer_id`),
>   KEY `frombranch` (`frombranch`),
>   KEY `tobranch` (`tobranch`),
>-- 
>2.35.3

Actions: View | Diff | Splinter Review

Attachments on bug 30600: 133696 | 134008 | 134344 | 134356 | 134618