Attachment 134656 Details for Bug 30688 – Bug 30688: Error in path to CSS background image

[patch] Bug 30688: Error in path to CSS background image

Bug-30688-Error-in-path-to-CSS-background-image.patch (text/plain), 2.05 KB, created by David Nind on 2022-05-05 19:49:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2022-05-05 19:49:23 UTC

Size: 2.05 KB

patch

obsolete

>From 70f972c185a526af92d8aaf52ea4b951d328fb49 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 5 May 2022 10:47:04 +0000
>Subject: [PATCH] Bug 30688: Error in path to CSS background image
>
>This patch corrects the path of an image specified as the background to
>a couple of elements in the OPAC. The incorrect path was causing 404
>errors.
>
>To test, apply the patch and rebuild the OPAC CSS
>(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
>
>- If necessary, activate one or more cover image services in
>  Administration, e.g. OPACAmazonCoverImages, OPACLocalCoverImages,
>  and/or OpenLibraryCovers.
>- In the OPAC, locate a bibliographic record which has a cover image
>  from one or more of the services you activated.
>- On the detail page for that record, the cover should load correctly.
>- In the browser console you should see no errors related to a file not
>  found: /opac-tmpl/bootstrap/img/spinner-small.gif
>- In the browser console, submit this JavaScript snippet:
>
>  $(".cover-image").remove();
>
>  The cover image should disappear, revealing the "spinner" icon behind
>  it.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
>index 6906e04db2..747251450f 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
>+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
>@@ -709,7 +709,7 @@ th {
> }
> 
> .cover-slides {
>-    background: #FFF url("../img/spinner-small.gif") center center no-repeat;
>+    background: #FFF url("../images/spinner-small.gif") center center no-repeat;
> 
>     .hint {
>         font-size: 80%;
>@@ -728,7 +728,7 @@ th {
> 
> td {
>     &.bookcover {
>-        background: #FFF url("../img/spinner-small.gif") center center no-repeat;
>+        background: #FFF url("../images/spinner-small.gif") center center no-repeat;
>         min-width: 120px;
>         text-align: center;
>     }
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30688: 134634 | 134656 | 134678