Attachment 134664 Details for Bug 30613 – Bug 30613: Hide RSS feed link when viewing private list in the OPAC

[patch] Bug 30613: Hide RSS feed link when viewing private list in the OPAC

Bug-30613-Hide-RSS-feed-link-when-viewing-private-.patch (text/plain), 2.22 KB, created by David Nind on 2022-05-05 21:10:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2022-05-05 21:10:42 UTC

Size: 2.22 KB

patch

obsolete

>From 9f26482d34a694641fc421f3aac8a59c597ac5f1 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 5 May 2022 14:02:26 +0000
>Subject: [PATCH] Bug 30613: Hide RSS feed link when viewing private list in
> the OPAC
>
>This patch wraps the List RSS icon in a check on whether the list is
>public. Private lists RSS can only be accessed by a logged-in patron.
>
>To test apply the patch and view a public list in the OPAC. You should
>see an RSS link icon next to the list title.
>
>Now log in to the OPAC and view a private list. There should be no RSS
>link.
>
>Note the QA tool warning about the aria-hidden attribute is a false
>positive. The parent element has a label.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>index df83785141..05388eb3e8 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>@@ -198,9 +198,11 @@
>                     [% IF shelf AND op == 'view' %]
>                         <h1>
>                             [% shelf.shelfname | html %]
>-                            <a href="[% OPACBaseURL | url %]/cgi-bin/koha/opac-shelves.pl?rss=1&amp;op=view&amp;shelfnumber=[% shelf.shelfnumber | uri %]" class="rss-list-link noprint" aria-label="Subscribe to this list">
>-                                <i class="fa fa-fw fa-rss rsssearchicon" aria-hidden="true" title="Subscribe to this list"></i>
>-                            </a>
>+                            [%  IF ( public ) %]
>+                                <a href="[% OPACBaseURL | url %]/cgi-bin/koha/opac-shelves.pl?rss=1&amp;op=view&amp;shelfnumber=[% shelf.shelfnumber | uri %]" class="rss-list-link noprint" aria-label="Subscribe to this list">
>+                                    <i class="fa fa-fw fa-rss rsssearchicon" aria-hidden="true" title="Subscribe to this list"></i>
>+                                </a>
>+                            [% END %]
>                         </h1>
> 
>                         [% IF ( itemsloop ) %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30613: 134641 | 134664 | 134677