Bugzilla – Attachment 134710 Details for
Bug 30551
Cash register report shows wrong library when paying fees in two different libraries
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30551: Make cash register report take branchcode from cash register
Bug-30551-Make-cash-register-report-take-branchcod.patch (text/plain), 2.12 KB, created by
Katrin Fischer
on 2022-05-06 08:48:00 UTC
(
hide
)
Description:
Bug 30551: Make cash register report take branchcode from cash register
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2022-05-06 08:48:00 UTC
Size:
2.12 KB
patch
obsolete
>From f70a0b4d6cb7b057f058484aaa3aebca8d555ae6 Mon Sep 17 00:00:00 2001 >From: Shi Yao Wang <shiyao@inlibro.com> >Date: Fri, 15 Apr 2022 12:37:34 -0400 >Subject: [PATCH] Bug 30551: Make cash register report take branchcode from > cash register > >This patch makes it so cash register reports puts branchcode from the >cash register where the payment was made into "Transaction library" >column instead of taking the branchcode of the manager. > >Test plan: >1- Use cash registers (administration > system preferences > UseCashRegisters) >2- Create another library if you only have one (administration > libraries > new library) >3- Create a cash register in each library if they don't already have one (administration > cash registers > new cash register) >4- Create a fee on your own account and pay it right after in both libraries. >5- Go to reports > cash register and generate the statistics. >6- Notice "transaction library" in both rows are the same even though the fees were paid in two different libraries and two different cash registers. >7- Apply the patch and click submit to re-generate statistics >8- Notice it now shows the correct library where the transactions were done > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> >--- > reports/cash_register_stats.pl | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/reports/cash_register_stats.pl b/reports/cash_register_stats.pl >index e043044844..871032941c 100755 >--- a/reports/cash_register_stats.pl >+++ b/reports/cash_register_stats.pl >@@ -108,7 +108,8 @@ if ($do_it) { > FROM accountlines al > LEFT JOIN borrowers bo ON (al.borrowernumber = bo.borrowernumber) > LEFT JOIN borrowers m ON (al.manager_id = m.borrowernumber) >- LEFT JOIN branches br ON (br.branchcode = m.branchcode ) >+ LEFT JOIN cash_registers cr ON (al.register_id = cr.id) >+ LEFT JOIN branches br ON (br.branchcode = cr.branch) > LEFT JOIN items i ON (i.itemnumber = al.itemnumber) > LEFT JOIN biblio bi ON (bi.biblionumber = i.biblionumber) > LEFT JOIN account_credit_types act ON (al.credit_type_code = act.code) >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30551
:
133362
|
134448
| 134710