Attachment 134713 Details for Bug 30703 – Bug 30703: Remove a few CookieManager warnings

[patch] Bug 30703: Remove a few CookieManager warnings

Bug-30703-Remove-a-few-CookieManager-warnings.patch (text/plain), 1.74 KB, created by Martin Renvoize (ashimema) on 2022-05-06 09:04:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2022-05-06 09:04:42 UTC

Size: 1.74 KB

patch

obsolete

>From f2ffa3f883b2e42f95b9c664aa5169f87685a2a8 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 6 May 2022 07:24:07 +0000
>Subject: [PATCH] Bug 30703: Remove a few CookieManager warnings
>
>Running Auth.t produces several warnings like:
>Use of uninitialized value $name in hash element at /usr/share/koha/Koha/CookieManager.pm line 103.
>Use of uninitialized value $name in hash element at /usr/share/koha/Koha/CookieManager.pm line 104.
>Use of uninitialized value $name in hash element at /usr/share/koha/Koha/CookieManager.pm line 112.
>Use of uninitialized value $name in hash element at /usr/share/koha/Koha/CookieManager.pm line 103.
>Use of uninitialized value $name in hash element at /usr/share/koha/Koha/CookieManager.pm line 104.
>Use of uninitialized value $name in hash element at /usr/share/koha/Koha/CookieManager.pm line 112.
>Use of uninitialized value $name in hash element at /usr/share/koha/Koha/CookieManager.pm line 103.
>Use of uninitialized value $name in hash element at /usr/share/koha/Koha/CookieManager.pm line 104.
>Use of uninitialized value $name in hash element at /usr/share/koha/Koha/CookieManager.pm line 112.
>
>Test plan:
>prove  t/CookieManager.t t/db_dependent/Auth.t
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> Koha/CookieManager.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/Koha/CookieManager.pm b/Koha/CookieManager.pm
>index d7680d8cc0..018c8068e1 100644
>--- a/Koha/CookieManager.pm
>+++ b/Koha/CookieManager.pm
>@@ -99,6 +99,7 @@ sub clear_unless {
>         } else {
>             $name = $c;
>         }
>+        next if !$name;
> 
>         if( !$self->{_remove_unless}->{$name} ) {
>             next if $seen->{$name};
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 30703: 134674 | 134713