Bugzilla – Attachment 134717 Details for
Bug 30638
Odd number of elements in anonymous hash at C4/Letters.pm line 827
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30638: Resolve odd number in hash warn in Letters
Bug-30638-Resolve-odd-number-in-hash-warn-in-Lette.patch (text/plain), 1.29 KB, created by
Katrin Fischer
on 2022-05-06 09:25:48 UTC
(
hide
)
Description:
Bug 30638: Resolve odd number in hash warn in Letters
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2022-05-06 09:25:48 UTC
Size:
1.29 KB
patch
obsolete
>From 1809c859d2c3b6d736bafb746001cb89f31c0515 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 28 Apr 2022 10:04:02 +0000 >Subject: [PATCH] Bug 30638: Resolve odd number in hash warn in Letters > >Odd number of elements in anonymous hash at C4/Letters.pm line 827. > >Trivial fix. Adding undefined check on result to prevent warns >on that one. > >No test plan. Read the patch. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> >--- > C4/Letters.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/C4/Letters.pm b/C4/Letters.pm >index 7c63b23d8e..9ed1de0e44 100644 >--- a/C4/Letters.pm >+++ b/C4/Letters.pm >@@ -824,8 +824,9 @@ sub _parseletter { > $dateonly = $1 unless $dateonly; > } > my $replacedby_date = eval { >- output_pref({ dt => dt_from_string( $replacedby ), dateonly => $dateonly }); >+ output_pref({ dt => scalar dt_from_string( $replacedby ), dateonly => $dateonly }); > }; >+ $replacedby_date //= q{}; > > if ( $letter->{ $letter_field } ) { > $letter->{ $letter_field } =~ s/\Q<<$table.$field$filter_string_used>>\E/$replacedby_date/g; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30638
:
134217
| 134717