Attachment 134764 Details for Bug 30714 – Bug 30714: Do no log update to holdingbranch

[patch] Bug 30714: Do no log update to holdingbranch

Bug-30714-Do-no-log-update-to-holdingbranch.patch (text/plain), 1.35 KB, created by Nick Clemens (kidclamp) on 2022-05-06 20:37:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2022-05-06 20:37:05 UTC

Size: 1.35 KB

patch

obsolete

>From 25c2ff0856f74fc458d841736c8fb3fd75b6e877 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 6 May 2022 20:32:32 +0000
>Subject: [PATCH] Bug 30714: Do no log update to holdingbranch
>
>When an item from another branch is checked in, the holdingbranch is updated, and this change is logged.  We record the checkin in statistics, we do not need the cataloguing update logged
>
>To recreate:
>1 - Enable cataloguing log
>2 - Check in an item with a different holding branch
>3 - Check the action logs
>4 - There is a cataloguing log for the holdingbranch update
>5 - Apply patch
>6 - Repeate with another item
>7 - No log added!
>---
> C4/Circulation.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index d312961478..47f0541f73 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -2207,7 +2207,7 @@ sub AddReturn {
>     # the holdingbranch is updated if the document is returned to another location.
>     # this is always done regardless of whether the item was on loan or not
>     if ($item->holdingbranch ne $branch) {
>-        $item->holdingbranch($branch)->store({ skip_record_index => 1, skip_holds_queue => 1 });
>+        $item->holdingbranch($branch)->store({ log_action => 0, skip_record_index => 1, skip_holds_queue => 1 });
>     }
> 
>     my $item_was_lost = $item->itemlost;
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30714: 134763 | 134764 | 134863 | 134864 | 135100