Attachment 134765 Details for Bug 30668 – Bug 30668: Unit tests

[patch] Bug 30668: Unit tests

Bug-30668-Unit-tests.patch (text/plain), 3.01 KB, created by David Nind on 2022-05-06 20:44:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2022-05-06 20:44:39 UTC

Size: 3.01 KB

patch

obsolete

>From 406b9a385bb543029ba63216628a769ea032513e Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 6 May 2022 20:09:27 +0000
>Subject: [PATCH] Bug 30668: Unit tests
>
>Simple test to cover UpdateNOtForLoanStatusOnCheckin and UpdateItemLocationOnCheckin
>to confirm the cataloguing log does not record these
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> t/db_dependent/Circulation/issue.t | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Circulation/issue.t b/t/db_dependent/Circulation/issue.t
>index f953b04dc5..81d5e6742c 100755
>--- a/t/db_dependent/Circulation/issue.t
>+++ b/t/db_dependent/Circulation/issue.t
>@@ -17,7 +17,7 @@
> 
> use Modern::Perl;
> 
>-use Test::More tests => 48;
>+use Test::More tests => 50;
> use DateTime::Duration;
> 
> use t::lib::Mocks;
>@@ -396,6 +396,9 @@ my $itemnumber = Koha::Item->new(
> )->store->itemnumber;
> 
> t::lib::Mocks::mock_preference( 'UpdateNotForLoanStatusOnCheckin', q{} );
>+t::lib::Mocks::mock_preference( 'CataloguingLog', 1 );
>+my $log_count_before = $schema->resultset('ActionLog')->search({module => 'CATALOGUING'})->count();
>+
> AddReturn( 'barcode_3', $branchcode_1 );
> my $item = Koha::Items->find( $itemnumber );
> ok( $item->notforloan eq 1, 'UpdateNotForLoanStatusOnCheckin does not modify value when not enabled' );
>@@ -404,6 +407,8 @@ t::lib::Mocks::mock_preference( 'UpdateNotForLoanStatusOnCheckin', '1: 9' );
> AddReturn( 'barcode_3', $branchcode_1 );
> $item = Koha::Items->find( $itemnumber );
> ok( $item->notforloan eq 9, q{UpdateNotForLoanStatusOnCheckin updates notforloan value from 1 to 9 with setting "1: 9"} );
>+my $log_count_after = $schema->resultset('ActionLog')->search({module => 'CATALOGUING'})->count();
>+is($log_count_before, $log_count_after, "Change from UpdateNotForLoanStatusOnCheckin is not logged");
> 
> AddReturn( 'barcode_3', $branchcode_1 );
> $item = Koha::Items->find( $itemnumber );
>@@ -427,10 +432,13 @@ my $item2 = Koha::Items->find( $itemnumber2 );
> ok( $item2->location eq 'FIC', 'UpdateItemLocationOnCheckin does not modify value when not enabled' );
> 
> t::lib::Mocks::mock_preference( 'UpdateItemLocationOnCheckin', 'FIC: GEN' );
>+$log_count_before = $schema->resultset('ActionLog')->search({module => 'CATALOGUING'})->count();
> AddReturn( 'barcode_4', $branchcode_1 );
> $item2 = Koha::Items->find( $itemnumber2 );
> is( $item2->location, 'GEN', q{UpdateItemLocationOnCheckin updates location value from 'FIC' to 'GEN' with setting "FIC: GEN"} );
> is( $item2->permanent_location, 'GEN', q{UpdateItemLocationOnCheckin updates permanent_location value from 'FIC' to 'GEN' with setting "FIC: GEN"} );
>+$log_count_after = $schema->resultset('ActionLog')->search({module => 'CATALOGUING'})->count();
>+is($log_count_before, $log_count_after, "Change from UpdateNotForLoanStatusOnCheckin is not logged");
> AddReturn( 'barcode_4', $branchcode_1 );
> $item2 = Koha::Items->find( $itemnumber2 );
> ok( $item2->location eq 'GEN', q{UpdateItemLocationOnCheckin does not update location value from 'GEN' with setting "FIC: GEN"} );
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30668: 134760 | 134761 | 134765 | 134766 | 134788 | 134789