Attachment 134863 Details for Bug 30714 – Bug 30714: Unit test

[patch] Bug 30714: Unit test

Bug-30714-Unit-test.patch (text/plain), 1.56 KB, created by Owen Leonard on 2022-05-11 11:06:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2022-05-11 11:06:52 UTC

Size: 1.56 KB

patch

obsolete

>From af30d4edcdea68e0589de59574e045c8f9862de6 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 6 May 2022 20:32:12 +0000
>Subject: [PATCH] Bug 30714: Unit test
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> t/db_dependent/Circulation/Branch.t | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Circulation/Branch.t b/t/db_dependent/Circulation/Branch.t
>index 00352acbc3..68a029d133 100755
>--- a/t/db_dependent/Circulation/Branch.t
>+++ b/t/db_dependent/Circulation/Branch.t
>@@ -25,7 +25,7 @@ use Koha::CirculationRules;
> 
> use Koha::Patrons;
> 
>-use Test::More tests => 16;
>+use Test::More tests => 17;
> use t::lib::Mocks;
> use t::lib::TestBuilder;
> 
>@@ -291,9 +291,13 @@ $query =
> "INSERT INTO issues (borrowernumber,itemnumber,branchcode) VALUES( ?,?,? )";
> $dbh->do( $query, {}, $borrower_id1, $item_id1, $samplebranch1->{branchcode} );
> 
>+t::lib::Mocks::mock_preference( 'CataloguingLog', 1 );
>+my $log_count_before = $schema->resultset('ActionLog')->search({module => 'CATALOGUING'})->count();
> my ($doreturn, $messages, $iteminformation, $borrower) = AddReturn('barcode_1',
>     $samplebranch2->{branchcode});
> is( $messages->{NeedsTransfer}, $samplebranch1->{branchcode}, "AddReturn respects default return policy - return to homebranch" );
>+my $log_count_after = $schema->resultset('ActionLog')->search({module => 'CATALOGUING'})->count();
>+is($log_count_before, $log_count_after, "Update to holdingbranch is not logged");
> 
> # item2 returned at branch2 should trigger transfer to holding branch
> $query =
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 30714: 134763 | 134764 | 134863 | 134864 | 135100