Bugzilla – Attachment 13489 Details for
Bug 9072
Add CheckValidity option to Linker
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed patch (follow-up 2)
0003-Bug-9072-Add-CheckValidity-option-to-Linker-followup2.patch (text/plain), 1.08 KB, created by
Fridolin Somers
on 2012-11-16 16:06:16 UTC
(
hide
)
Description:
Proposed patch (follow-up 2)
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2012-11-16 16:06:16 UTC
Size:
1.08 KB
patch
obsolete
>From fe1c7328b4558821db67cb67b15862002bc72792 Mon Sep 17 00:00:00 2001 >From: Fridolyn SOMERS <fridolyn.somers@biblibre.com> >Date: Fri, 16 Nov 2012 16:40:59 +0100 >Subject: [PATCH 3/4] Bug 9072: Add CheckValidity option to Linker (followup > 2) Avoid null for string compare in > C4::Biblio::_check_valid_auth_link > >--- > C4/Biblio.pm | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > >diff --git a/C4/Biblio.pm b/C4/Biblio.pm >index eb213d5..50fc85d 100644 >--- a/C4/Biblio.pm >+++ b/C4/Biblio.pm >@@ -663,12 +663,15 @@ safest place. > sub _check_valid_auth_link { > my ( $authid, $field ) = @_; > >- require C4::AuthoritiesMarc; >+ my $field_value = $field->as_string('abcdefghijklmnopqrstuvwxyz'); >+ return unless $field_value; > >+ require C4::AuthoritiesMarc; > my $authorized_heading = > C4::AuthoritiesMarc::GetAuthorizedHeading( { 'authid' => $authid } ); >+ return unless $authorized_heading; > >- return ($field->as_string('abcdefghijklmnopqrstuvwxyz') eq $authorized_heading); >+ return ($field_value eq $authorized_heading); > } > > =head2 GetRecordValue >-- >1.7.9.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9072
:
13442
|
13481
|
13482
|
13483
|
13487
|
13488
| 13489 |
13490