Attachment 134899 Details for Bug 29051 – Bug 29051: Update svc api to allow seen renewals

[patch] Bug 29051: Update svc api to allow seen renewals

Bug-29051-Update-svc-api-to-allow-seen-renewals.patch (text/plain), 1.12 KB, created by Martin Renvoize (ashimema) on 2022-05-11 15:22:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2022-05-11 15:22:56 UTC

Size: 1.12 KB

patch

obsolete

>From eeb38615711522e3793eaacb48bc0c8a49762532 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 11 May 2022 16:21:48 +0100
>Subject: [PATCH] Bug 29051: Update svc api to allow seen renewals
>
>This patch updates the svc/renew api endpoint to allow seen renewals
>when appropriate
>---
> svc/renew | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/svc/renew b/svc/renew
>index 91f7958031..470c02e796 100755
>--- a/svc/renew
>+++ b/svc/renew
>@@ -67,10 +67,12 @@ if ( $data->{error} && $data->{error} eq 'on_reserve' && C4::Context->preference
>     $data->{error} = undef;
> }
> 
>-if ( $data->{renew_okay} ) {
>+if ( $data->{renew_okay} || ( $seen && $data->{error} eq 'too_unseen') ) {
>     try{
>         $date_due = AddRenewal( $borrowernumber, $itemnumber, $branchcode, $date_due, undef, undef, $seen );
>         $data->{date_due} = output_pref( { dt => $date_due, as_due_date => 1 } );
>+        $data->{renew_okay} = 1;
>+        $data->{error} = undef;
>     } catch {
>         if ( ref($_) eq 'Koha::Exceptions::Checkout::FailedRenewal' ) {
>             $data->{error} = 'renewal_failed';
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29051: 134898 | 134899 | 136780 | 136782 | 137271 | 137272