Bugzilla – Attachment 134919 Details for
Bug 30731
Noise from about script coming from Test::MockTime (or other CPAN modules)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30731: Remove Readonly::XS::MAGIC_COOKIE
Bug-30731-Remove-ReadonlyXSMAGICCOOKIE.patch (text/plain), 1.08 KB, created by
David Nind
on 2022-05-12 08:15:57 UTC
(
hide
)
Description:
Bug 30731: Remove Readonly::XS::MAGIC_COOKIE
Filename:
MIME Type:
Creator:
David Nind
Created:
2022-05-12 08:15:57 UTC
Size:
1.08 KB
patch
obsolete
>From 91516955f0e344bda4443f87c0f247f1599ea532 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 12 May 2022 07:05:50 +0000 >Subject: [PATCH] Bug 30731: Remove Readonly::XS::MAGIC_COOKIE > >This variable does not make sense anymore, since the Readonly::XS >module is not listed in the cpanfile. So it will not be required >the versions_info loop. > >Test plan: >Run t/Installer_PerlModules.t again. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: David Nind <david@davidnind.com> >--- > C4/Installer/PerlModules.pm | 2 -- > 1 file changed, 2 deletions(-) > >diff --git a/C4/Installer/PerlModules.pm b/C4/Installer/PerlModules.pm >index a66dc03899..5d4a84ecda 100644 >--- a/C4/Installer/PerlModules.pm >+++ b/C4/Installer/PerlModules.pm >@@ -72,8 +72,6 @@ sub versions_info { > } > > my $attr; >- >- $Readonly::XS::MAGIC_COOKIE="Do NOT use or require Readonly::XS unless you're me."; > { > # ignore warnings from noisy modules > local $SIG{__WARN__} = sub {}; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30731
:
134913
|
134914
|
134915
|
134917
|
134918
|
134919
|
134960
|
134961
|
134962