Attachment 134925 Details for Bug 30195 – The patch passes the provided test cases under t/db_dependent/Suggestions.t as well as several manual tests using different existing ISBNs inside opac-suggestions.pl

[patch] The patch passes the provided test cases under t/db_dependent/Suggestions.t as well as several manual tests using different existing ISBNs inside opac-suggestions.pl

The-patch-passes-the-provided-test-cases-under-tdb.patch (text/plain), 1.17 KB, created by Paul Derscheid on 2022-05-12 12:01:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Paul Derscheid

Created: 2022-05-12 12:01:44 UTC

Size: 1.17 KB

patch

obsolete

>From 8546cf52182c440a275d5247859811891b7344ad Mon Sep 17 00:00:00 2001
>From: Paul Derscheid <paul.derscheid@lmscloud.de>
>Date: Thu, 12 May 2022 11:50:44 +0000
>Subject: [PATCH] The patch passes the provided test cases under
> t/db_dependent/Suggestions.t as well as several manual tests using different
> existing ISBNs inside opac-suggestions.pl
>
>https://bugs.koha-community.org/show_bug.cgi?id=30195
>Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
>---
> t/db_dependent/Suggestions.t | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Suggestions.t b/t/db_dependent/Suggestions.t
>index b0e810804b..4df723a888 100755
>--- a/t/db_dependent/Suggestions.t
>+++ b/t/db_dependent/Suggestions.t
>@@ -18,7 +18,7 @@
> use Modern::Perl;
> 
> use DateTime::Duration;
>-use Test::More tests => 106;
>+use Test::More tests => 107;
> use Test::Warn;
> 
> use t::lib::Mocks;
>@@ -668,6 +668,6 @@ subtest 'Suggestion with ISBN' => sub {
> 
>     my ($author_tag, $author_subfield) = C4::Biblio::GetMarcFromKohaField('biblio.author', '');
>     is($record->field( $author_tag), undef, "Record from suggestion author should be emtpy");
>-}
>+};
> 
> $schema->storage->txn_rollback;
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 30195: 131731 | 134923 | 134924 | 134925 | 135264 | 135265 | 135474 | 135475 | 135476