Attachment 134936 Details for Bug 12446 – Bug 12446: Fixing QA tool's tests

[patch] Bug 12446: Fixing QA tool's tests

Bug-12446-Fixing-QA-tools-tests.patch (text/plain), 2.65 KB, created by Shi Yao Wang on 2022-05-12 15:26:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Shi Yao Wang

Created: 2022-05-12 15:26:16 UTC

Size: 2.65 KB

patch

obsolete

>From df7c483f2364d0271c861a71ca29c32b09d28744 Mon Sep 17 00:00:00 2001
>From: The Minh Luong <theminh@inlibro.com>
>Date: Fri, 22 Apr 2022 10:28:00 -0400
>Subject: [PATCH] Bug 12446: Fixing QA tool's tests
>
>This patch fixes tests that fails by the QA test tool.
>I removed the debug variable, since it is not used.
>I also got a few spelling check errors when I ran the QA test tool. I corrected them too.
>
>To test:
>1) Create an Adult AND Child category in Administration/Patron
>categories
>2) Create a child AND adult patron.
>3) Go in your child patron's page.
>4) Click on "Edit".
>5) Notice that you can add a guarantor with "Add guarantor" button.
>6) Go in your adult patron's page.
>7) Click on "Edit".
>8) Notice that there is no "Add guarantor" button. Therefore, you can't
>add a guarantor for this patron.
>9) Apply patch and run updatedatabase.pl
>10) Go in Administration/Patron categories and edit one of them.
>12) Notice that you can see the new "Can be guarantee" field.
>13) Set "Yes" on the "Can be guarantee" field for your Child AND Adult
>category.
>14) Repeat steps 6 to 7.
>15) Notice that your adult patron can now add guarantors with the "Add
>guarantor" button.
>16) prove t/db_dependent/Patrons.t
>    => All tests should still pass
>17) Run the QA test tool. All tests should say OK
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> members/memberentry.pl | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/members/memberentry.pl b/members/memberentry.pl
>index 5fbb46818d..507fc60142 100755
>--- a/members/memberentry.pl
>+++ b/members/memberentry.pl
>@@ -824,7 +824,6 @@ if (C4::Context->preference('EnhancedMessagingPreferences')) {
> 
> $template->param( borrower_data => \%data );
> $template->param( "show_guarantor" => $categorycode ? Koha::Patron::Categories->find($categorycode)->canbeguarantee : 1); # associate with step to know where you are
>-my $debug and warn "memberentry step: $step";
> $template->param( "step_$step"  => 1) if $step;	# associate with step to know where u are
> $template->param(  step  => $step   ) if $step;	# associate with step to know where u are
> 
>@@ -832,7 +831,7 @@ $template->param(
>   BorrowerMandatoryField => C4::Context->preference("BorrowerMandatoryField"),#field to test with javascript
>   category_type => $category_type,#to know the category type of the borrower
>   "$category_type"  => 1,# associate with step to know where u are
>-  destination   => $destination,#to know wher u come from and wher u must go in redirect
>+  destination   => $destination,#to know where u come from and where u must go in redirect
>   check_member    => $check_member,#to know if the borrower already exist(=>1) or not (=>0) 
>   "op$op"   => 1);
> 
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 12446: 29278 | 36176 | 39744 | 42469 | 42470 | 42535 | 46277 | 46278 | 46327 | 46328 | 46345 | 46486 | 49793 | 50953 | 53534 | 53535 | 53536 | 53913 | 60929 | 60930 | 60934 | 63148 | 63149 | 63214 | 64793 | 64794 | 64828 | 72295 | 72883 | 77766 | 77767 | 77768 | 79343 | 79344 | 79345 | 79347 | 79348 | 85069 | 88364 | 88365 | 88366 | 88367 | 90389 | 90390 | 90391 | 90392 | 90470 | 90471 | 90472 | 90473 | 93388 | 93389 | 93390 | 93391 | 93392 | 93393 | 93394 | 95411 | 95853 | 95854 | 95855 | 95856 | 95857 | 95858 | 95859 | 95860 | 106753 | 106754 | 106755 | 106756 | 106757 | 107611 | 111052 | 111053 | 111317 | 111318 | 112102 | 112160 | 112161 | 112162 | 112163 | 113583 | 121925 | 121926 | 121927 | 121928 | 121929 | 122084 | 122085 | 122086 | 122087 | 122088 | 122089 | 122090 | 122091 | 122184 | 122185 | 122186 | 122187 | 130398 | 130399 | 130400 | 130401 | 130402 | 131965 | 131966 | 131967 | 131968 | 131969 | 133691 | 133952 | 133953 | 133954 | 133955 | 133956 | 133957 | 134930 | 134931 | 134932 | 134933 | 134934 | 134935 | 134936 | 135506 | 135507 | 135508 | 135509 | 135510 | 135511 | 135512 | 135519 | 135520 | 135521 | 135522 | 135523 | 135544 | 135545 | 142401 | 142408 | 142431 | 142432 | 142433 | 142434 | 142435 | 142436 | 142437 | 142438 | 142439