Bugzilla – Attachment 134949 Details for
Bug 30721
Markup error in detail page's component parts tab
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30721: Markup error in detail page's component parts tab
Bug-30721-Markup-error-in-detail-pages-component-p.patch (text/plain), 2.00 KB, created by
Katrin Fischer
on 2022-05-13 07:55:44 UTC
(
hide
)
Description:
Bug 30721: Markup error in detail page's component parts tab
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2022-05-13 07:55:44 UTC
Size:
2.00 KB
patch
obsolete
>From ea7b566a7ff03904515f4ac71773252a460fa07c Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 9 May 2022 15:22:16 +0000 >Subject: [PATCH] Bug 30721: Markup error in detail page's component parts tab > >This patch adds a missing </div> to the bibliographic detail >page template in the section for showing component parts. >Some comments are added to clarify the markup structure. > >To test you should have a record in your catalog with component >parts. Bug 11175 provides one you can import if necessary: >https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78023 > >To see the error, go to the staff interface, locate the record >in question and view the detail page. Under the Components tag, >scroll to the bottom. You will see content from "later" tabs at >the bottom, e.g. "There is no order for this bibliographic record" >or "No images have been uploaded for this bibliograhpic record yet." > >Apply the patch and reload the page. The tabs should still look >correct, and now the tab content should be correctly isolated. > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index 054d3b97b7..cb6b22e709 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -708,7 +708,8 @@ Note that permanent location is a code, and location may be an authval. > [% IF ComponentParts.size == Koha.Preference('MaxComponentRecords')%] > <p>Only [% ComponentParts.size | html %] results are shown: <a href="/cgi-bin/koha/catalogue/search.pl?q=[% ComponentPartsQuery | uri %]"/>show all component parts</a></p> > [% END %] >-</div> >+ </div> <!-- /.content_set --> >+</div> <!-- /#components --> > > [% END %] > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30721
:
134786
|
134800
| 134949