Attachment 135001 Details for Bug 30629 – Bug 30629: fix in title of some pages

[patch] Bug 30629: fix in title of some pages

Bug-30629-fix-span-in-title-of-some-pages.patch (text/plain), 4.62 KB, created by David Nind on 2022-05-14 22:22:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2022-05-14 22:22:30 UTC

Size: 4.62 KB

patch

obsolete

>From 7e6b80a2505f27b437d32ad8bf1893740e2ce60e Mon Sep 17 00:00:00 2001
>From: Victor Grousset/tuxayo <victor@tuxayo.net>
>Date: Fri, 13 May 2022 21:25:53 +0200
>Subject: [PATCH] Bug 30629: fix in title of some pages
>
>== Test plan ==
>1. Go to http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=layout
>2. See that the page title in your browser window title is wrong because it contains 
>3. Go to http://localhost:8081/cgi-bin/koha/labels/label-manage.pl?label_element=batch
>4. See that the page title in your browser window title is wrong because it contains 
>5. Go to http://localhost:8081/cgi-bin/koha/admin/aqbudgetperiods.pl
>6. Administration => Budgets => Click on a budget => planning => plan by months
>7. See that the page title in your browser window title is wrong because it contains 
>8. Refresh the pages and see that the titles are correct
>9. Sign off :)
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> .../prog/en/includes/budget_planning.inc | 7 ++++---
> .../prog/en/modules/labels/label-manage.tt | 17 +++++++++--------
> .../prog/en/modules/patroncards/manage.tt | 19 ++++++++++---------
> 3 files changed, 23 insertions(+), 20 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/budget_planning.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/budget_planning.inc
>index d1f2dc78ae..e502eb3af4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/budget_planning.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/budget_planning.inc
>@@ -1,7 +1,8 @@
>+[% PROCESS 'i18n.inc' %]
> [%- BLOCK planning -%]
> [%- SWITCH plan -%]
>- [%- CASE 'MONTHS' -%]by months
>- [%- CASE 'BRANCHES' -%]by libraries
>- [%- CASE 'ITEMTYPES' -%]by item types
>+ [%- CASE 'MONTHS' -%][% t('by months') | html %]
>+ [%- CASE 'BRANCHES' -%][% t('by libraries') | html %]
>+ [%- CASE 'ITEMTYPES' -%][% t('by item types') | html %]
> [%- END -%]
> [%- END -%]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-manage.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-manage.tt
>index a1d66abdd7..d64c60d531 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-manage.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-manage.tt
>@@ -1,16 +1,17 @@
> [% USE raw %]
> [% USE Asset %]
>+[% PROCESS 'i18n.inc' %]
> [% SET footerjs = 1 %]
> [% BLOCK translate_label_element %]
> [%- SWITCH element -%]
>-[%- CASE 'layout' -%]layout
>-[%- CASE 'Layouts' -%]Layouts
>-[%- CASE 'template' -%]template
>-[%- CASE 'Templates' -%]Templates
>-[%- CASE 'profile' -%]profile
>-[%- CASE 'Profiles' -%]Profiles
>-[%- CASE 'batch' -%]batch
>-[%- CASE 'Batches' -%]Batches
>+[%- CASE 'layout' -%][% t('layout') | html %]
>+[%- CASE 'Layouts' -%][% t('Layouts') | html %]
>+[%- CASE 'template' -%][% t('template') | html %]
>+[%- CASE 'Templates' -%][% t('Templates') | html %]
>+[%- CASE 'profile' -%][% t('profile') | html %]
>+[%- CASE 'Profiles' -%][% t('Profiles') | html %]
>+[%- CASE 'batch' -%][% t('batch') | html %]
>+[%- CASE 'Batches' -%][% t('Batches') | html %]
> [%- END -%]
> [% END %]
> [% INCLUDE 'doc-head-open.inc' %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/manage.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/manage.tt
>index ec48b90ab5..81bef9eef3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/manage.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/manage.tt
>@@ -1,16 +1,17 @@
> [% USE CGI %]
>+[% PROCESS 'i18n.inc' %]
> [% SET footerjs = 1 %]
> [% BLOCK translate_card_element %]
> [%- SWITCH element -%]
>-[%- CASE 'layout' -%]layout
>-[%- CASE 'Layouts' -%]Layouts
>-[%- CASE 'template' -%]template
>-[%- CASE 'Templates' -%]Templates
>-[%- CASE 'profile' -%]profile
>-[%- CASE 'Profiles' -%]Profiles
>-[%- CASE 'batch' -%]batch
>-[%- CASE 'Batches' -%]Batches
>-[%- CASE 'Actions' -%]Actions
>+[%- CASE 'layout' -%][% t('layout') | html %]
>+[%- CASE 'Layouts' -%][% t('Layouts') | html %]
>+[%- CASE 'template' -%][% t('template') | html %]
>+[%- CASE 'Templates' -%][% t('Templates') | html %]
>+[%- CASE 'profile' -%][% t('profile') | html %]
>+[%- CASE 'Profiles' -%][% t('Profiles') | html %]
>+[%- CASE 'batch' -%][% t('batch') | html %]
>+[%- CASE 'Batches' -%][% t('Batches') | html %]
>+[%- CASE 'Actions' -%][% t('Actions') | html %]
> [%- END -%]
> [% END %]
> [% BLOCK translate_card_elements %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30629: 134989 | 134990 | 135001 | 135096