Bugzilla – Attachment 135051 Details for
Bug 30779
Do not need to remove items from import biblios marc
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30779: Do not update import marc after importing items
Bug-30779-Do-not-update-import-marc-after-importin.patch (text/plain), 1.45 KB, created by
Nick Clemens (kidclamp)
on 2022-05-16 20:01:15 UTC
(
hide
)
Description:
Bug 30779: Do not update import marc after importing items
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2022-05-16 20:01:15 UTC
Size:
1.45 KB
patch
obsolete
>From ac91c170329c03c2e446df41f683a0307f472f5b Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 16 May 2022 19:57:23 +0000 >Subject: [PATCH] Bug 30779: Do not update import marc after importing items > >We are stripping the marc item tags at import - we save them when not importing items, but >strip when importing items > >I think we can save on writes by leaving them in the record. This also allows comparison to what was staged >versus items created > >To test: > 1 - Stage a marc record with items, but do not look for items > 2 - Confirm the item tags remain in staged marc > 3 - Import the record > 4 - Confirm items are nto in imported marc record > 5 - Stage the record again, but look for items > 6 - Confirm the item tags are stipped from imported record > 7 - Import and confirm imported record has no item tags > 8 - Apply patch and repeat 1-5 > 9 - Confirm item tags remain in record >10 - Import and confirm item tags not in imported marc >--- > C4/ImportBatch.pm | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/C4/ImportBatch.pm b/C4/ImportBatch.pm >index ee47b98811..e57d4bdb03 100644 >--- a/C4/ImportBatch.pm >+++ b/C4/ImportBatch.pm >@@ -456,7 +456,6 @@ sub AddItemsToImportBiblio { > > if ($#import_items_ids > -1) { > _update_batch_record_counts($batch_id) if $update_counts; >- _update_import_record_marc($import_record_id, $marc_record, C4::Context->preference('marcflavour')); > } > return @import_items_ids; > } >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30779
:
135051
|
138475
|
139275
|
139285
|
139287
|
139288