Bugzilla – Attachment 135098 Details for
Bug 30797
Subfields linked to the dateaccessioned.pl value builder on addbiblio.pl throw a JS error
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30797: Add the calendar.inc include to addbiblio.tt
Bug-30797-Add-the-calendarinc-include-to-addbiblio.patch (text/plain), 2.00 KB, created by
Marcel de Rooy
on 2022-05-18 11:11:36 UTC
(
hide
)
Description:
Bug 30797: Add the calendar.inc include to addbiblio.tt
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2022-05-18 11:11:36 UTC
Size:
2.00 KB
patch
obsolete
>From 45463f03d0c1b4a97124fdc4d175be108663ad4b Mon Sep 17 00:00:00 2001 >From: Alex Buckley <alexbuckley@catalyst.net.nz> >Date: Wed, 18 May 2022 04:07:06 +0000 >Subject: [PATCH] Bug 30797: Add the calendar.inc include to addbiblio.tt >Content-Type: text/plain; charset=utf-8 > >addbiblio.tt throws the '$(...).flatpickr is not a function' because it >is missing includes to flatpickr.min.js and shortcut-buttons-flatpickr.min.js > >To fix this the addbiblio.tt should include the calendar.inc file (like >additem.tt does) which includes to those aforementioned JS files. > >Test plan: >1. Edit a MARC bibliographic framework >2. Make the 902$d subfield visible in the Editor >3. Also set the 902$d subfield plugin='dateaccessioned.pl' >4. Catalogue a new biblio record >5. Notice the 902$d subfield has not been pre-populated with todays date >6. Right click, choose 'Inspect', observe this JS error in the console: "Uncaught >TypeError: $(...).flatpickr is not a function" >7. Apply patch, and restart services >8. Repeat steps 4-6 and this time observe the 902$d is pre-populated, >and there is no flatpickr JS error in the console > >Sponsored-by: Chartered Accountants Australia and New Zealand > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >index 523812f377..cb6a16f905 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >@@ -4,6 +4,7 @@ > [% INCLUDE 'doc-head-open.inc' %] > <title>[% IF ( biblionumber ) %]Editing [% title | html %] (Record number [% biblionumber | html %])[% ELSE %]Add MARC record[% END %] › Cataloging › Koha</title> > [% INCLUDE 'doc-head-close.inc' %] >+[% INCLUDE 'calendar.inc' %] > [% Asset.js("lib/hc-sticky.js") | $raw %] > [% INCLUDE 'select2.inc' %] > <script> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30797
:
135088
| 135098 |
135103