Bugzilla – Attachment 135121 Details for
Bug 30507
Value builder for UNIMARC field 183
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30507: Value builder for field 183
Bug-30507-Value-builder-for-field-183.patch (text/plain), 18.91 KB, created by
Jérémy Breuillard
on 2022-05-18 14:30:21 UTC
(
hide
)
Description:
Bug 30507: Value builder for field 183
Filename:
MIME Type:
Creator:
Jérémy Breuillard
Created:
2022-05-18 14:30:21 UTC
Size:
18.91 KB
patch
obsolete
>From 61b3cfe0d8009d0a6a8f6603937057b00bb426b6 Mon Sep 17 00:00:00 2001 >From: jeremy breuillard <jeremy.breuillard@biblibre.com> >Date: Wed, 18 May 2022 16:24:37 +0200 >Subject: [PATCH] Bug 30507: Value builder for field 183 > >This patch provides values builders for the subfields $a and $2. Those are unimarc official codes who help to >identify the kind of items > >Test plan: >1)Go to Home > Cataloging > New record >2)Section 1 - field 183 : it contains subfields $a & $2 >3)Inputs are writable but notice that no plugins are suggested >4)Apply patch and repeat 1) to 3) >5)Values builders plugins are available for $a and $2 >--- > .../value_builder/unimarc_field_182a.pl | 74 ------------ > .../value_builder/unimarc_field_182c.pl | 74 ------------ > ..._field_182-2.pl => unimarc_field_183-2.pl} | 4 +- > .../value_builder/unimarc_field_183a.pl | 2 - > .../value_builder/unimarc_field_182-2.tt | 58 ---------- > .../value_builder/unimarc_field_182a.tt | 95 ---------------- > .../value_builder/unimarc_field_182c.tt | 105 ------------------ > .../value_builder/unimarc_field_183-2.tt | 2 +- > 8 files changed, 3 insertions(+), 411 deletions(-) > delete mode 100755 cataloguing/value_builder/unimarc_field_182a.pl > delete mode 100755 cataloguing/value_builder/unimarc_field_182c.pl > rename cataloguing/value_builder/{unimarc_field_182-2.pl => unimarc_field_183-2.pl} (96%) > delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182-2.tt > delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182a.tt > delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182c.tt > >diff --git a/cataloguing/value_builder/unimarc_field_182a.pl b/cataloguing/value_builder/unimarc_field_182a.pl >deleted file mode 100755 >index e9eea3a384..0000000000 >--- a/cataloguing/value_builder/unimarc_field_182a.pl >+++ /dev/null >@@ -1,74 +0,0 @@ >-#!/usr/bin/perl >- >-# Copyright 2014 Rijksmuseum >-# >-# This file is part of Koha. >-# >-# Koha is free software; you can redistribute it and/or modify it >-# under the terms of the GNU General Public License as published by >-# the Free Software Foundation; either version 3 of the License, or >-# (at your option) any later version. >-# >-# Koha is distributed in the hope that it will be useful, but >-# WITHOUT ANY WARRANTY; without even the implied warranty of >-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >-# GNU General Public License for more details. >-# >-# You should have received a copy of the GNU General Public License >-# along with Koha; if not, see <http://www.gnu.org/licenses>. >- >-use Modern::Perl; >- >-use Date::Calc; >- >-use Koha::Util::FrameworkPlugin qw(wrapper); >-use C4::Auth qw( get_template_and_user ); >-use CGI qw ( -utf8 ); >-use C4::Context; >-use C4::Output qw( output_html_with_http_headers ); >- >-my $builder= sub { >- my $params = shift; >- my $id = $params->{id}; >- >- return qq| >-<script> >- >-function Click$id(event) { >- var fieldvalue=\$('#'+event.data.id).val(); >- window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_182a.pl&index=\"+event.data.id+\"&result=\"+fieldvalue,\"tag_editor\",'width=700,height=700,toolbar=false,scrollbars=yes'); >- return false; /* prevents scrolling */ >-} >-</script>|; >-}; >- >-my $launcher= sub { >- my $params = shift; >- my $cgi = $params->{cgi}; >- my ( $template, $loggedinuser, $cookie ) = get_template_and_user({ >- template_name => "cataloguing/value_builder/unimarc_field_182a.tt", >- query => $cgi, >- type => "intranet", >- flagsrequired => {editcatalogue => '*'}, >- }); >- my $results = scalar $cgi->param('result'); >- >- $template->param( >- index => scalar $cgi->param('index'), >- result => $results, >- ); >- >- # Return the result of the position in the string, ex: abcde = 1=a, 2=b, 3=c... >- my @x = split(//, $results); >- my $i = 1; >- for my $fresult (@x) { >- $template->param("f$i" => $fresult); >- ++$i; >- } >- output_html_with_http_headers $cgi, $cookie, $template->output; >-}; >- >-# Return the hashref with the builder and launcher to FrameworkPlugin object. >-# NOTE: If you do not need a popup but only use e.g. Focus, Blur etc. for a >-# particular plugin, you only need to define and return the builder. >-return { builder => $builder, launcher => $launcher }; >diff --git a/cataloguing/value_builder/unimarc_field_182c.pl b/cataloguing/value_builder/unimarc_field_182c.pl >deleted file mode 100755 >index 0d39da435b..0000000000 >--- a/cataloguing/value_builder/unimarc_field_182c.pl >+++ /dev/null >@@ -1,74 +0,0 @@ >-#!/usr/bin/perl >- >-# Copyright 2014 Rijksmuseum >-# >-# This file is part of Koha. >-# >-# Koha is free software; you can redistribute it and/or modify it >-# under the terms of the GNU General Public License as published by >-# the Free Software Foundation; either version 3 of the License, or >-# (at your option) any later version. >-# >-# Koha is distributed in the hope that it will be useful, but >-# WITHOUT ANY WARRANTY; without even the implied warranty of >-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >-# GNU General Public License for more details. >-# >-# You should have received a copy of the GNU General Public License >-# along with Koha; if not, see <http://www.gnu.org/licenses>. >- >-use Modern::Perl; >- >-use Date::Calc; >- >-use Koha::Util::FrameworkPlugin qw(wrapper); >-use C4::Auth qw( get_template_and_user ); >-use CGI qw ( -utf8 ); >-use C4::Context; >-use C4::Output qw( output_html_with_http_headers ); >- >-my $builder= sub { >- my $params = shift; >- my $id = $params->{id}; >- >- return qq| >-<script> >- >-function Click$id(event) { >- var fieldvalue=\$('#'+event.data.id).val(); >- window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_182c.pl&index=\"+event.data.id+\"&result=\"+fieldvalue,\"tag_editor\",'width=700,height=700,toolbar=false,scrollbars=yes'); >- return false; /* prevents scrolling */ >-} >-</script>|; >-}; >- >-my $launcher= sub { >- my $params = shift; >- my $cgi = $params->{cgi}; >- my ( $template, $loggedinuser, $cookie ) = get_template_and_user({ >- template_name => "cataloguing/value_builder/unimarc_field_182c.tt", >- query => $cgi, >- type => "intranet", >- flagsrequired => {editcatalogue => '*'}, >- }); >- my $results = scalar $cgi->param('result'); >- >- $template->param( >- index => scalar $cgi->param('index'), >- result => $results, >- ); >- >- # Return the result of the position in the string, ex: abcde = 1=a, 2=b, 3=c... >- my @x = split(//, $results); >- my $i = 1; >- for my $fresult (@x) { >- $template->param("f$i" => $fresult); >- ++$i; >- } >- output_html_with_http_headers $cgi, $cookie, $template->output; >-}; >- >-# Return the hashref with the builder and launcher to FrameworkPlugin object. >-# NOTE: If you do not need a popup but only use e.g. Focus, Blur etc. for a >-# particular plugin, you only need to define and return the builder. >-return { builder => $builder, launcher => $launcher }; >diff --git a/cataloguing/value_builder/unimarc_field_182-2.pl b/cataloguing/value_builder/unimarc_field_183-2.pl >similarity index 96% >rename from cataloguing/value_builder/unimarc_field_182-2.pl >rename to cataloguing/value_builder/unimarc_field_183-2.pl >index 02a93db86e..c717bb39e5 100755 >--- a/cataloguing/value_builder/unimarc_field_182-2.pl >+++ b/cataloguing/value_builder/unimarc_field_183-2.pl >@@ -36,7 +36,7 @@ my $builder= sub { > > function Click$id(event) { > var fieldvalue=\$('#'+event.data.id).val(); >- window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_182-2.pl&index=\"+event.data.id+\"&result=\"+fieldvalue,\"tag_editor\",'width=700,height=700,toolbar=false,scrollbars=yes'); >+ window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_183-2.pl&index=\"+event.data.id+\"&result=\"+fieldvalue,\"tag_editor\",'width=700,height=700,toolbar=false,scrollbars=yes'); > return false; /* prevents scrolling */ > } > </script>|; >@@ -46,7 +46,7 @@ my $launcher= sub { > my $params = shift; > my $cgi = $params->{cgi}; > my ( $template, $loggedinuser, $cookie ) = get_template_and_user({ >- template_name => "cataloguing/value_builder/unimarc_field_182-2.tt", >+ template_name => "cataloguing/value_builder/unimarc_field_183-2.tt", > query => $cgi, > type => "intranet", > flagsrequired => {editcatalogue => '*'}, >diff --git a/cataloguing/value_builder/unimarc_field_183a.pl b/cataloguing/value_builder/unimarc_field_183a.pl >index a66e4b7417..3d84bad848 100755 >--- a/cataloguing/value_builder/unimarc_field_183a.pl >+++ b/cataloguing/value_builder/unimarc_field_183a.pl >@@ -26,8 +26,6 @@ use C4::Auth qw( get_template_and_user ); > use CGI qw ( -utf8 ); > use C4::Context; > use C4::Output qw( output_html_with_http_headers ); >-use Data::Dumper; >- > > my $builder= sub { > my $params = shift; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182-2.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182-2.tt >deleted file mode 100644 >index b759a2d21c..0000000000 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182-2.tt >+++ /dev/null >@@ -1,58 +0,0 @@ >-[% INCLUDE 'doc-head-open.inc' %] >-<title>Framework plugin example › Cataloguing › Koha</title> >-[% INCLUDE 'doc-head-close.inc' %] >-</head> >- >-<body id="cat_unimarc_field_182-2" class="cat" style="padding:1em;"> >- >-<h3>UNIMARC field 182-2 builder</h3> >- >-<form name="f_pop" action=""> >-<table> >- <tr> >- <td><label for="f0">System code :</label></td> >- <td> >- <select name="f0" id="f0"> >- [% IF ( f0 == "carr" ) %] >- <option value="RDAcarrier" selected="selected">RDA Carrier</option> >- [% ELSE %] >- <option value="RDAcarrier">RDA Carrier</option> >- [% END %] >- >- [% IF ( f0 == "cont" ) %] >- <option value="RDAcontent" selected="selected">RDA Content</option> >- [% ELSE %] >- <option value="RDAcontent">RDA Content</option> >- [% END %] >- >- [% IF ( f0 == "media" ) %] >- <option value="RDAmedia" selected="selected">RDA Media</option> >- [% ELSE %] >- <option value="RDAmedia">RDA Media</option> >- [% END %] >- >- [% IF ( f0 == "frcarr" ) %] >- <option value="RDAfrCarrier" selected="selected">RDA fr Carrier</option> >- [% ELSE %] >- <option value="RDAfrCarrier">RDA fr Carrier</option> >- [% END %] >- </select> >- </td> >- </tr> >-</table> >-<p><input type="button" value="OK" onclick="submitMyForm();" /> <a href="#" class="cancel close">Cancel</a> </p> >-</form> >- >-<script> >- >- function submitMyForm() { >- var doc = opener.document; >- var field = doc.getElementById("[% index | html %]"); >- >- field.value = document.f_pop.f0.value; >- window.close(); >- return false; >- } >-</script> >- >-[% INCLUDE 'popup-bottom.inc' %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182a.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182a.tt >deleted file mode 100644 >index 03030b48b2..0000000000 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182a.tt >+++ /dev/null >@@ -1,95 +0,0 @@ >-[% INCLUDE 'doc-head-open.inc' %] >-<title>Framework plugin example › Cataloguing › Koha</title> >-[% INCLUDE 'doc-head-close.inc' %] >-</head> >- >-<body id="cat_unimarc_field_182a" class="cat" style="padding:1em;"> >- >-<h3>UNIMARC field 182a builder</h3> >- >-<form name="f_pop" action=""> >-<table> >- <tr> >- <td><label for="f1">Media Type Code </label></td> >- <td> >- <select name="f1" id="f1"> >- [% IF ( f1 == "a" ) %] >- <option value="a" selected="selected">a - audio</option> >- [% ELSE %] >- <option value="a">a - audio</option> >- [% END %] >- >- [% IF ( f1 == "b" ) %] >- <option value="b" selected="selected">b - electronic</option> >- [% ELSE %] >- <option value="b">b - electronic</option> >- [% END %] >- >- [% IF ( f1 == "c" ) %] >- <option value="c" selected="selected">c - microform</option> >- [% ELSE %] >- <option value="c">c - microform</option> >- [% END %] >- >- [% IF ( f1 == "d" ) %] >- <option value="d" selected="selected">d - microscopic</option> >- [% ELSE %] >- <option value="d">d - microscopic</option> >- [% END %] >- >- [% IF ( f1 == "e" ) %] >- <option value="e" selected="selected">e - projected</option> >- [% ELSE %] >- <option value="e">e - projected</option> >- [% END %] >- >- [% IF ( f1 == "f" ) %] >- <option value="f" selected="selected">f - stereographic</option> >- [% ELSE %] >- <option value="f">f - stereographic</option> >- [% END %] >- >- [% IF ( f1 == "g" ) %] >- <option value="g" selected="selected">g - video</option> >- [% ELSE %] >- <option value="g">g - video</option> >- [% END %] >- >- [% IF ( f1 == "m" ) %] >- <option value="m" selected="selected">m - multiple media</option> >- [% ELSE %] >- <option value="m">m - multiple media</option> >- [% END %] >- >- [% IF ( f1 == "n" ) %] >- <option value="n" selected="selected">n - unmediated</option> >- [% ELSE %] >- <option value="n">n - unmediated</option> >- [% END %] >- >- [% IF ( f1 == "z" ) %] >- <option value="z" selected="selected">z - other media</option> >- [% ELSE %] >- <option value="z">z - other media</option> >- [% END %] >- </select> >- </td> >- </tr> >- >-</table> >-<p><input type="button" value="OK" onclick="submitMyForm();" /> <a href="#" class="cancel close">Cancel</a> </p> >-</form> >- >-<script> >- >- function submitMyForm() { >- var doc = opener.document; >- var field = doc.getElementById("[% index | html %]"); >- >- field.value = document.f_pop.f1.value; >- window.close(); >- return false; >- } >-</script> >- >-[% INCLUDE 'popup-bottom.inc' %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182c.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182c.tt >deleted file mode 100644 >index e6eccb1922..0000000000 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182c.tt >+++ /dev/null >@@ -1,105 +0,0 @@ >-[% INCLUDE 'doc-head-open.inc' %] >-<title>Framework plugin example › Cataloguing › Koha</title> >-[% INCLUDE 'doc-head-close.inc' %] >-</head> >- >-<body id="cat_unimarc_field_181c" class="cat" style="padding:1em;"> >- >-<h3>UNIMARC field 182c builder</h3> >- >-<form name="f_pop" action=""> >-<table> >- <tr> >- <td><label for="f1">Media Type </label></td> >- <td> >- <select name="f1" id="f1"> >- [% IF ( f1 == "s" ) %] >- <option value="s" selected="selected">s - audio</option> >- [% ELSE %] >- <option value="s">s - audio</option> >- [% END %] >- >- [% IF ( f1 == "c" ) %] >- <option value="c" selected="selected">c - computer</option> >- [% ELSE %] >- <option value="c">c - computer</option> >- [% END %] >- >- [% IF ( f1 == "h" ) %] >- <option value="h" selected="selected">h - microform</option> >- [% ELSE %] >- <option value="h">h - microform</option> >- [% END %] >- >- [% IF ( f1 == "p" ) %] >- <option value="p" selected="selected">p - microscopic</option> >- [% ELSE %] >- <option value="p">p - microscopic</option> >- [% END %] >- >- [% IF ( f1 == "g" ) %] >- <option value="g" selected="selected">g - projected</option> >- [% ELSE %] >- <option value="g">g - projected</option> >- [% END %] >- >- [% IF ( f1 == "e" ) %] >- <option value="e" selected="selected">e - stereographic</option> >- [% ELSE %] >- <option value="e">e - stereographic</option> >- [% END %] >- >- [% IF ( f1 == "n" ) %] >- <option value="n" selected="selected">n - unmediated</option> >- [% ELSE %] >- <option value="n">n - unmediated</option> >- [% END %] >- >- [% IF ( f1 == "v" ) %] >- <option value="v" selected="selected">v - video</option> >- [% ELSE %] >- <option value="v">v - video</option> >- [% END %] >- >- [% IF ( f1 == "x" ) %] >- <option value="x" selected="selected">x - other</option> >- [% ELSE %] >- <option value="x">x - other</option> >- [% END %] >- >- [% IF ( f1 == "z" ) %] >- <option value="z" selected="selected">z - unspecified</option> >- [% ELSE %] >- <option value="z">z - unspecified</option> >- [% END %] >- </select> >- </td> >- </tr> >- >-</table> >-<p><input type="button" value="OK" onclick="submitMyForm();" /> <a href="#" class="cancel close">Cancel</a> </p> >-</form> >- >-<script> >- >- function submitMyForm() { >- var doc = opener.document; >- var field = doc.getElementById("[% index | html %]"); >- subfield(); >- >- function subfield() { >- const tag = $(field).closest('.tag'); >- const sub = tag.find('[id*="tag_182_subfield_2_"]'); >- if ( field !== undefined ) { >- sub[0].value = "RDAmedia"; >- } >- return subfield; >- } >- >- field.value = document.f_pop.f1.value; >- window.close(); >- return false; >- } >-</script> >- >-[% INCLUDE 'popup-bottom.inc' %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_183-2.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_183-2.tt >index a9532f7677..112c106e95 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_183-2.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_183-2.tt >@@ -3,7 +3,7 @@ > [% INCLUDE 'doc-head-close.inc' %] > </head> > >-<body id="cat_unimarc_field_181-2" class="cat" style="padding:1em;"> >+<body id="cat_unimarc_field_183-2" class="cat" style="padding:1em;"> > > <h3>UNIMARC field 183-2 builder</h3> > >-- >2.17.1
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=135121">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30507
:
133152
|
135121
|
135195
|
135196
|
135198
|
139476