Attachment 135146 Details for Bug 27697 – Bug 27697: Only preopulate search when we have found a single biblio

[patch] Bug 27697: Only preopulate search when we have found a single biblio

Bug-27697-Only-preopulate-search-when-we-have-foun.patch (text/plain), 2.90 KB, created by Nick Clemens (kidclamp) on 2022-05-18 15:13:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2022-05-18 15:13:38 UTC

Size: 2.90 KB

patch

obsolete

>From fb6e7bf092fabcb2b00f27ede4ac4d695b414913 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 18 May 2022 15:08:39 +0000
>Subject: [PATCH] Bug 27697: Only preopulate search when we have found a single
> biblio
>
>This patch uses the url parameter we created in 23475 to determine whether
>we should populate the search bar or not
>
>Note - a bookmark with this param will still populate search term with last search
>
>To test:
>1 - Search staff client for 'cat'
>2 - Browse to a patrons checkouts and click on a title, or just go directly to a details page:
>    http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=2850
>3 - Search bar says 'cat'
>4 - Apply patch
>5 - Repeat 1-2
>6 - Search bar is not populated
>7 - Search "dalek war box set" or a term that finds a single record in your instance
>8 - Search bar is populated
>9 - Note url like: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=2850&found1=1
>---
> catalogue/detail.pl                                |  2 ++
> .../prog/en/modules/catalogue/detail.tt            | 14 ++++++++------
> 2 files changed, 10 insertions(+), 6 deletions(-)
>
>diff --git a/catalogue/detail.pl b/catalogue/detail.pl
>index 9687f3b01b..a467df62be 100755
>--- a/catalogue/detail.pl
>+++ b/catalogue/detail.pl
>@@ -619,6 +619,8 @@ if ( C4::Context->preference('UseCourseReserves') ) {
>     $template->param( course_reserves => $course_reserves );
> }
> 
>+$template->param(found1 => $query->param('found1') );
>+
> $template->param(biblio => $biblio);
> 
> output_html_with_http_headers $query, $cookie, $template->output;
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index cb6b22e709..24e92e0994 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -1406,12 +1406,14 @@ Note that permanent location is a code, and location may be an authval.
>             [% END %]
>         });
> 
>-        $(document).ready(function() {
>-            var search_index = localStorage.getItem("cat_search_pulldown_selection");
>-            var search_value = localStorage.getItem("searchbox_value");
>-            if ( search_index ){ $('#cat-search-block select.advsearch').val(search_index)};
>-            if ( search_value ){ $('#cat-search-block #search-form').val(search_value)};
>-        });
>+        [% IF (found1) %]
>+            $(document).ready(function() {
>+                var search_index = localStorage.getItem("cat_search_pulldown_selection");
>+                var search_value = localStorage.getItem("searchbox_value");
>+                if ( search_index ){ $('#cat-search-block select.advsearch').val(search_index)};
>+                if ( search_value ){ $('#cat-search-block #search-form').val(search_value)};
>+            });
>+        [% END %]
>     </script>
> [% END %]
> [% INCLUDE 'intranet-bottom.inc' %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 27697: 135146 | 135457 | 135468