Bugzilla – Attachment 135171 Details for
Bug 22456
Allow patrons to cancel their waiting holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22456: Staff interface handling WIP
Bug-22456-Staff-interface-handling-WIP.patch (text/plain), 2.89 KB, created by
Tomás Cohen Arazi (tcohen)
on 2022-05-18 20:41:02 UTC
(
hide
)
Description:
Bug 22456: Staff interface handling WIP
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2022-05-18 20:41:02 UTC
Size:
2.89 KB
patch
obsolete
>From 1e4d55c7b718b15ba1d6c4a4febecbc88356708f Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 18 May 2022 17:38:37 -0300 >Subject: [PATCH] Bug 22456: Staff interface handling WIP > >--- > circ/waitingreserves.pl | 6 ++++++ > .../prog/en/modules/circ/waitingreserves.tt | 12 ++++++++++++ > 2 files changed, 18 insertions(+) > >diff --git a/circ/waitingreserves.pl b/circ/waitingreserves.pl >index 608fb49d3f..195ff30422 100755 >--- a/circ/waitingreserves.pl >+++ b/circ/waitingreserves.pl >@@ -28,6 +28,7 @@ use Date::Calc qw( Date_to_Days Today ); > use C4::Reserves qw( ModReserve ModReserveCancelAll ); > use Koha::DateUtils qw( dt_from_string output_pref ); > use Koha::BiblioFrameworks; >+use Koha::Hold::CancellationRequests; > use Koha::Items; > use Koha::ItemTypes; > use Koha::Patrons; >@@ -116,6 +117,10 @@ while ( my $hold = $holds->next ) { > > } > >+my $holds_with_cancellation_requests = >+ Koha::Hold::CancellationRequests->filter_by_current->search( {}, >+ { distinct => 'hold_id' } )->get_column('hold_id'); >+ > $template->param(cancel_result => \@cancel_result) if @cancel_result; > > $template->param( >@@ -123,6 +128,7 @@ $template->param( > reservecount => scalar @reserve_loop, > overloop => \@over_loop, > overcount => scalar @over_loop, >+ cancel_reqs => $holds_with_cancellation_requests, > show_date => output_pref({ dt => dt_from_string, dateformat => 'iso', dateonly => 1 }), > tab => $tab, > ); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt >index b6e06f7bc9..c1824f0570 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt >@@ -88,6 +88,11 @@ > Holds waiting over [% Koha.Preference('ReservesMaxPickUpDelay') | html %] days: [% overcount | html %] > </a> > </li> >+ <li role="presentation"> >+ <a href="#holds-with-cancellation-requests" aria-controls="holds-with-cancellation-requests" role="tab" data-toggle="tab"> >+ Holds with cancellation requests: [% cancel_reqs | html %] >+ </a> >+ </li> > </ul> > <div class="tab-content"> > <div role="tabpanel" class="tab-pane active" id="holdswaiting"> >@@ -125,6 +130,13 @@ > <div class="dialog message">No holds found.</div> > [% END %] > </div> >+ <div role="tabpanel" class="tab-pane" id="holds-with-cancellation-requests"> >+ [% IF cancel_reqs %] >+ <div class="dialog message">Table goes here.</div> >+ [% ELSE %] >+ <div class="dialog message">No holds found.</div> >+ [% END %] >+ </div> > </div> > [% END %] > >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22456
:
135165
|
135166
|
135167
|
135168
|
135169
|
135170
|
135171
|
135319
|
135320
|
135321
|
135322
|
135323
|
135324
|
135325
|
135326
|
135349
|
135350
|
135351
|
135352
|
135396
|
135397
|
135398
|
135399
|
135400
|
135401
|
135402
|
135403
|
135404
|
135405
|
135406
|
135407
|
135408
|
135409
|
135410
|
135411
|
135430
|
135830
|
135831
|
135832
|
135838
|
135839
|
135840
|
135841
|
135842
|
135843
|
135844
|
135845
|
135846
|
137580
|
137581
|
137582
|
137583
|
137584
|
137585
|
137586
|
137587
|
137588
|
137589
|
137591
|
138209
|
138210
|
138211
|
138212
|
138213
|
138214
|
138215
|
138216
|
138217
|
138218