Bugzilla – Attachment 13520 Details for
Bug 7167
updatedatabase improvements
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7167: Changing in .sql parsing
Bug-7167-Changing-in-sql-parsing.patch (text/plain), 1.52 KB, created by
Chris Nighswonger
on 2012-11-19 15:45:25 UTC
(
hide
)
Description:
Bug 7167: Changing in .sql parsing
Filename:
MIME Type:
Creator:
Chris Nighswonger
Created:
2012-11-19 15:45:25 UTC
Size:
1.52 KB
patch
obsolete
>From 6793ea2c4774d68cfb94b4dc72b14bbf4a56e64d Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Tue, 31 Jul 2012 10:50:21 +0200 >Subject: [PATCH] Bug 7167: Changing in .sql parsing >Content-Type: text/plain; charset="utf-8" > >We first split on delimiter and then extract comments. You can now put >\n for delimiter comments. >ex: > >DELIMITER ; >-- this is a comment >SELECT * FROM my_table; >-- another comment > >Before this patch, we had to write: >DELIMITER ; >-- this is a comment; >SELECT * FROM my_table; >-- another comment; > >Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> >Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> >--- > C4/Update/Database.pm | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > >diff --git a/C4/Update/Database.pm b/C4/Update/Database.pm >index 8ab5840..ac62209 100644 >--- a/C4/Update/Database.pm >+++ b/C4/Update/Database.pm >@@ -370,6 +370,20 @@ sub get_queries { > chomp $line; > $line =~ s/^\s*//; > if ( $line =~ s/^--(.*)$// ) { >+ my @l = split $old_delimiter; >+ if ( @l > 1 ) { >+ my $tmp_query; >+ for my $l ( @l ) { >+ if ( $l =~ m/^--/ ) { >+ push @comments, $l; >+ next; >+ } >+ $tmp_query .= $l . $old_delimiter; >+ } >+ push @queries, $tmp_query if $tmp_query; >+ next; >+ } >+ > push @comments, $1; > next; > } >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7167
:
6377
|
6378
|
6379
|
6381
|
6414
|
6415
|
6416
|
6476
|
6477
|
6478
|
6479
|
6722
|
6832
|
7903
|
8178
|
9859
|
9860
|
9861
|
9862
|
10033
|
10034
|
10549
|
10666
|
10667
|
10668
|
10825
|
11129
|
11222
|
11223
|
11224
|
11225
|
11226
|
11227
|
11228
|
11229
|
11230
|
11231
|
11232
|
11235
|
11236
|
11237
|
11238
|
11239
|
11240
|
11241
|
11242
|
11243
|
11244
|
11245
|
11246
|
11571
|
13423
|
13424
|
13425
|
13426
|
13427
|
13428
|
13429
|
13430
|
13431
|
13432
|
13433
|
13434
|
13435
|
13436
|
13437
|
13456
|
13457
|
13509
|
13516
|
13517
|
13518
|
13519
|
13520
|
13521
|
13522
|
13523
|
13524
|
13525
|
13526
|
13527
|
13528
|
13529
|
13733
|
13734
|
13842
|
13845
|
13848
|
13851
|
13852
|
13853
|
13854
|
14310
|
16113
|
16114
|
16115
|
16116
|
16117
|
16596