Bugzilla – Attachment 135220 Details for
Bug 30781
Use of uninitialized value $val in substitution iterator at /usr/share/koha/lib/C4/Letters.pm line 665.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30781: Fix warning in GetPreparedLetter
Bug-30781-Fix-warning-in-GetPreparedLetter.patch (text/plain), 880 bytes, created by
David Nind
on 2022-05-19 20:10:06 UTC
(
hide
)
Description:
Bug 30781: Fix warning in GetPreparedLetter
Filename:
MIME Type:
Creator:
David Nind
Created:
2022-05-19 20:10:06 UTC
Size:
880 bytes
patch
obsolete
>From 9cfb380f544348a592bbc94a21cc0754de0be288 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Wed, 18 May 2022 17:50:13 -1000 >Subject: [PATCH] Bug 30781: Fix warning in GetPreparedLetter > >Test by running : > prove t/db_dependent/Letters.t >Check you dont see warning : > Use of uninitialized value $val in substitution iterator > >Signed-off-by: David Nind <david@davidnind.com> >--- > C4/Letters.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/C4/Letters.pm b/C4/Letters.pm >index 9ed1de0e44..8ab0bb727e 100644 >--- a/C4/Letters.pm >+++ b/C4/Letters.pm >@@ -599,6 +599,7 @@ sub GetPreparedLetter { > > if (%$substitute) { > while ( my ($token, $val) = each %$substitute ) { >+ $val //= q{}; > if ( $token eq 'items.content' ) { > $val =~ s|\n|<br/>|g if $letter->{is_html}; > } >-- >2.30.2
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=135220">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30781
:
135177
|
135178
|
135192
|
135193
|
135219
|
135220
|
135222