Bugzilla – Attachment 135227 Details for
Bug 30788
Argument "" isn't numeric in multiplication (*) at /usr/share/koha/lib/C4/Overdues.pm
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30788: Fix warning in Overdues.pm when fine is empty in circ rules
Bug-30788-Fix-warning-in-Overduespm-when-fine-is-e.patch (text/plain), 1.57 KB, created by
Martin Renvoize (ashimema)
on 2022-05-20 08:50:48 UTC
(
hide
)
Description:
Bug 30788: Fix warning in Overdues.pm when fine is empty in circ rules
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-05-20 08:50:48 UTC
Size:
1.57 KB
patch
obsolete
>From e4edc1d0888c48f18886a9dd4625e194d7c564b4 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer@bsz-bw.de> >Date: Fri, 20 May 2022 09:43:15 +0200 >Subject: [PATCH] Bug 30788: Fix warning in Overdues.pm when fine is empty in > circ rules > >Argument "" isn't numeric in multiplication (*) at /usr/share/koha/lib/C4/Overdues.pm > >To test: >* Create a issuing rule where fine is empty, but a fine interval is set. > Fine amount: empty > To do this, remove the 0 displayed in the input field before saving. > Fine charging interval: 5 or any other numeric value > When to charge: Start of interval > Fine grace period: 0 >* Check out an item with the due date yester (use specify due date) >* Run misc/cronjobs/fines.pl -v >* You should see above warn in the output >* Apply patch >* Rerun fines.pl, there should be no warn. >* Run: > t/db_dependent/Circulation/CalcFine.t > t/db_dependent/Fines.t > t/db_dependent/Circulation.t > t/db_dependent/Overdues.t > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/Overdues.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Overdues.pm b/C4/Overdues.pm >index 5db9c22041..a31d2b4f7b 100644 >--- a/C4/Overdues.pm >+++ b/C4/Overdues.pm >@@ -274,7 +274,7 @@ sub CalcFine { > # biblio-level recall > $amount = $charge_periods * $issuing_rule->{recall_overdue_fine}; > } >- if ( scalar @recalls == 0 ) { >+ if ( scalar @recalls == 0 && $issuing_rule->{fine}) { > # no recall, use normal fine amount > $amount = $charge_periods * $issuing_rule->{fine}; > } >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30788
:
135225
|
135226
| 135227 |
135228
|
135229
|
135554