Bugzilla – Attachment 135235 Details for
Bug 30813
Refactor TransformMarcToKoha to remove TransformMarcToKohaOneField
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30813: Remove Koha::MetadataRecord::getKohaField
Bug-30813-Remove-KohaMetadataRecordgetKohaField.patch (text/plain), 1014 bytes, created by
Nick Clemens (kidclamp)
on 2022-05-20 10:24:15 UTC
(
hide
)
Description:
Bug 30813: Remove Koha::MetadataRecord::getKohaField
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2022-05-20 10:24:15 UTC
Size:
1014 bytes
patch
obsolete
>From 2bd7a42b7c5eba95fecfd70711fdf675702e9f72 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 20 May 2022 10:08:11 +0000 >Subject: [PATCH] Bug 30813: Remove Koha::MetadataRecord::getKohaField > >This was essentially a wrapper around TransformKohaToMarcOneField > >After changing and updating, it seems easier not to create the intermediary >object and to just transform the data >--- > Koha/MetadataRecord.pm | 13 ------------- > 1 file changed, 13 deletions(-) > >diff --git a/Koha/MetadataRecord.pm b/Koha/MetadataRecord.pm >index 840f63b386..b288d98c1d 100644 >--- a/Koha/MetadataRecord.pm >+++ b/Koha/MetadataRecord.pm >@@ -109,17 +109,4 @@ sub createMergeHash { > } > } > >-=head2 getKohaField >- >- $metadata->{$key} = $record->getKohaField($kohafield); >- >-=cut >- >-sub getKohaField { >- my ($self, $kohafield) = @_; >- if ($self->schema =~ m/marc/) { >- return C4::Biblio::TransformMarcToKoha({ kohafields => [$kohafield], record => $self->record}); >- } >-} >- > 1; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30813
:
135232
|
135233
|
135234
|
135235
|
135239
|
135240
|
135241
|
135242
|
135243
|
135302
|
135303
|
135304
|
135305
|
135306
|
135371
|
135374
|
135375
|
135376
|
135377
|
135378
|
135379
|
135763
|
135764
|
135765
|
135766
|
135767
|
135768
|
135769
|
135803
|
135825