Bugzilla – Attachment 135299 Details for
Bug 30838
to_address is misleading for SMS transports
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30838: Set to_address to smsalertnumber at send
Bug-30838-Set-toaddress-to-smsalertnumber-at-send.patch (text/plain), 965 bytes, created by
Martin Renvoize (ashimema)
on 2022-05-24 11:58:16 UTC
(
hide
)
Description:
Bug 30838: Set to_address to smsalertnumber at send
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-05-24 11:58:16 UTC
Size:
965 bytes
patch
obsolete
>From 74501e6d86ec7929a13cea67617108707773169c Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 24 May 2022 12:57:09 +0100 >Subject: [PATCH] Bug 30838: Set to_address to smsalertnumber at send > >It may be helpful to know exactly what number was used for the sms alert >that was sent. As such, we should ensure it's set at the time of >sending. >--- > C4/Letters.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/C4/Letters.pm b/C4/Letters.pm >index 9ed1de0e44..94f0816a49 100644 >--- a/C4/Letters.pm >+++ b/C4/Letters.pm >@@ -1489,6 +1489,7 @@ sub _is_duplicate { > sub _send_message_by_sms { > my $message = shift or return; > my $patron = Koha::Patrons->find( $message->{borrowernumber} ); >+ _update_message_to_address($message->{message_id}, $patron->smsalertnumber) if $patron; > > unless ( $patron and $patron->smsalertnumber ) { > _set_message_status( { message_id => $message->{'message_id'}, >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30838
:
135298
|
135299
|
136674
|
136675
|
136676
|
137202
|
138025
|
138026
|
138027
|
138028
|
138052