Attachment 135344 Details for Bug 30847 – Bug 30847: Remove %itemInfoHash

[patch] Bug 30847: Remove %itemInfoHash

Bug-30847-Remove-itemInfoHash.patch (text/plain), 1.11 KB, created by Nick Clemens (kidclamp) on 2022-05-25 15:09:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2022-05-25 15:09:56 UTC

Size: 1.11 KB

patch

obsolete

>From b9226b591247da56d51765d4673bbe3b82ee38a2 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 25 May 2022 14:28:08 +0000
>Subject: [PATCH] Bug 30847: Remove %itemInfoHash
>
>This is not used
>
>git grep itemInfoHash
>only 2 occurences - definition and population - never used
>---
> opac/opac-reserve.pl | 4 ----
> 1 file changed, 4 deletions(-)
>
>diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl
>index 741e6e8822..748a08d168 100755
>--- a/opac/opac-reserve.pl
>+++ b/opac/opac-reserve.pl
>@@ -136,7 +136,6 @@ $template->param( branch => $branch );
> #
> 
> my %biblioDataHash; # Hash of biblionumber to biblio/biblioitems record.
>-my %itemInfoHash; # Hash of itemnumber to item info.
> foreach my $biblioNumber (@biblionumbers) {
> 
>     my $biblioData = GetBiblioData($biblioNumber);
>@@ -154,9 +153,6 @@ foreach my $biblioNumber (@biblionumbers) {
>     }
> 
>     $biblioData->{itemInfos} = \@itemInfos;
>-    foreach my $itemInfo (@itemInfos) {
>-        $itemInfoHash{$itemInfo->{itemnumber}} = $itemInfo;
>-    }
> 
>     # Compute the priority rank.
>     my $biblio = Koha::Biblios->find( $biblioNumber );
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30847: 135340 | 135341 | 135342 | 135343 | 135344 | 135345 | 135346 | 135347 | 135348 | 137668 | 137669 | 137670 | 137671 | 137672 | 137673 | 137674 | 137675 | 138654 | 138655 | 138934 | 138935 | 138936 | 138937 | 138938 | 138939 | 138940 | 138941 | 139628 | 139629 | 139630 | 139631 | 139632 | 139633 | 139634 | 139635 | 139915 | 139916 | 139917 | 139918 | 139919 | 139920 | 139921 | 139922 | 139923