Attachment 135392 Details for Bug 30854 – Bug 30854: (QA follow-up) Spec fixes

[patch] Bug 30854: (QA follow-up) Spec fixes

Bug-30854-QA-follow-up-Spec-fixes.patch (text/plain), 1.95 KB, created by Martin Renvoize (ashimema) on 2022-05-26 16:38:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2022-05-26 16:38:02 UTC

Size: 1.95 KB

patch

obsolete

>From 3b94fd394aa8debb0bc3561308a551347aa5a98e Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Thu, 26 May 2022 10:42:29 -0300
>Subject: [PATCH] Bug 30854: (QA follow-up) Spec fixes
>
>This patch fixes minor spec QA issues:
>
>* Missing summary for routes
>* Missing error_code description for 500
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> api/v1/swagger/paths/import_record_matches.yaml | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
>diff --git a/api/v1/swagger/paths/import_record_matches.yaml b/api/v1/swagger/paths/import_record_matches.yaml
>index b3ee9c9685..7536e4d8fd 100644
>--- a/api/v1/swagger/paths/import_record_matches.yaml
>+++ b/api/v1/swagger/paths/import_record_matches.yaml
>@@ -3,6 +3,7 @@
>   put:
>     x-mojo-to: ImportRecordMatches#set_chosen
>     operationId: setChosen
>+    summary: Set the chosen match for an import record ID
>     tags:
>       - import_batches
>     parameters:
>@@ -51,7 +52,10 @@
>         schema:
>           $ref: "../swagger.yaml#/definitions/error"
>       "500":
>-        description: Internal server error
>+        description: |
>+          Internal server error. Possible `error_code` attribute values:
>+
>+          * `internal_server_error`
>         schema:
>           $ref: "../swagger.yaml#/definitions/error"
>       "503":
>@@ -64,6 +68,7 @@
>   delete:
>     x-mojo-to: ImportRecordMatches#unset_chosen
>     operationId: unsetChosen
>+    summary: Unset the chosen match for an import record ID
>     tags:
>       - import_batches
>     parameters:
>@@ -95,7 +100,10 @@
>         schema:
>           $ref: "../swagger.yaml#/definitions/error"
>       "500":
>-        description: Internal server error
>+        description: |
>+          Internal server error. Possible `error_code` attribute values:
>+
>+          * `internal_server_error`
>         schema:
>           $ref: "../swagger.yaml#/definitions/error"
>       "503":
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 30854: 135382 | 135383 | 135391 | 135392