Bugzilla – Attachment 135419 Details for
Bug 30028
Patron message delete confirmation untranslatable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30028: Fix patron message delete confirmation translation (fr-CA)
Bug-30028-Fix-patron-message-delete-confirmation-t.patch (text/plain), 3.99 KB, created by
Shi Yao Wang
on 2022-05-27 12:45:52 UTC
(
hide
)
Description:
Bug 30028: Fix patron message delete confirmation translation (fr-CA)
Filename:
MIME Type:
Creator:
Shi Yao Wang
Created:
2022-05-27 12:45:52 UTC
Size:
3.99 KB
patch
obsolete
>From 4ae874806d48c66ac857e2d46657b7a7ec48d88e Mon Sep 17 00:00:00 2001 >From: Shi Yao Wang <shiyao@inlibro.com> >Date: Fri, 25 Mar 2022 13:27:23 -0400 >Subject: [PATCH] Bug 30028: Fix patron message delete confirmation translation > (fr-CA) >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >When we delete a patron message, there is a confirmation message that is >not translated. Here is the fix (for fr-CA translations) > >Test plan: >1) Switch language to french (fr-CA) >If you do not have the translations, go to > misc/translator >then do > ./translate install fr-CA >After it is done, go to administration > global system preference > >l18N/L10N then select Français (fr-CA) under language preference. >Refresh then you should be able to switch languages. >2) Add a message to a patron account from your own branch (or make sure AllowAllMessageDeletion is on) >3) Click "Delete" next to the message >--> a confirmation message appears "Are you sure you want to delete this message? This cannot be undone." with options "Cancel" and "OK". >4) Apply the patch >5) Refresh the translations by going to misc/translator and execute ./translate install fr-CA >6) Refresh and click "Delete" again >--> now the confirmation message is "Ãtes-vous sûr de vouloir supprimer ce message? Cette opération est irréversible." with options "Cancel" and "OK" >--- > .../intranet-tmpl/prog/en/includes/patron_messages.inc | 9 ++++++++- > misc/translator/po/fr-CA-staff-prog.po | 5 +++++ > 2 files changed, 13 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc >index 97219917e7..83363630bf 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc >@@ -202,6 +202,13 @@ > [% END # /IF patron.borrowernotes %] > > [% IF ( patron_messages ) %] >+ <script> >+ function confirm_deletion() { >+ if (confirm(_("Are you sure you want to delete this message? This cannot be undone."))) { >+ window.location="/cgi-bin/koha/circ/del_message.pl?message_id=[% patron_message.message_id | html %]&borrowernumber=[% patron_message.borrowernumber | html %]&from=moremember"; >+ } >+ } >+ </script> > <div id="messages" class="circmessage"> > <h4>Messages</h4> > <ul> >@@ -220,7 +227,7 @@ > <em>"[% patron_message.message | html %]"</em> > </span> > [% IF patron_message.branchcode == Branches.GetLoggedInBranchcode OR Koha.Preference('AllowAllMessageDeletion') %] >- <a class="btn btn-link" href="/cgi-bin/koha/circ/del_message.pl?message_id=[% patron_message.message_id | html %]&borrowernumber=[% patron_message.borrowernumber | html %]&from=moremember" onclick='return confirm(_("Are you sure you want to delete this message? This cannot be undone."));'><i class="fa fa-trash"></i> Delete</a> >+ <a class="btn btn-link" href="javascript:confirm_deletion()"><i class="fa fa-trash"></i> Delete</a> > [% END %] > </li> > [% END %] >diff --git a/misc/translator/po/fr-CA-staff-prog.po b/misc/translator/po/fr-CA-staff-prog.po >index 6f674a4e61..4af98267e9 100644 >--- a/misc/translator/po/fr-CA-staff-prog.po >+++ b/misc/translator/po/fr-CA-staff-prog.po >@@ -13581,6 +13581,11 @@ msgstr "Voulez-vous vraiment supprimer cette macro?" > msgid "Are you sure you want to delete this message?" > msgstr "Voulez-vous vraiment supprimer ce message?" > >+#. SCRIPT >+#: koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc:205 >+msgid "Are you sure you want to delete this message? This cannot be undone." >+msgstr "Ãtes-vous sûr de vouloir supprimer ce message? Cette opération est irréversible." >+ > #. SCRIPT > #: koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt:268 > msgid "Are you sure you want to delete this news item? This cannot be undone." >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30028
:
132250
|
132251
|
135419
|
135432
|
135441
|
135548
|
135562
|
135584
|
137597
|
138453