Attachment 135449 Details for Bug 30786 – Bug 30786: Fix capitalization in advanced search system preferences

[patch] Bug 30786: Fix capitalization in advanced search system preferences

Bug-30786-Fix-capitalization-in-advanced-search-sy.patch (text/plain), 3.14 KB, created by Victor Grousset/tuxayo on 2022-05-30 18:07:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Victor Grousset/tuxayo

Created: 2022-05-30 18:07:16 UTC

Size: 3.14 KB

patch

obsolete

>From eac5a0040787ae0eebbfa969ded32219bce3cc7e Mon Sep 17 00:00:00 2001
>From: David Nind <david@davidnind.com>
>Date: Wed, 18 May 2022 02:21:14 +0000
>Subject: [PATCH] Bug 30786: Fix capitalization in advanced search system
> preferences
>
>This fixes the capitalization in the descriptions for the
>AdvancedSearchTypes and OpacAdvancedSearchTypes system preferences.
>
>Test plan:
>1. In the staff interface, search the system preferences for
> 'AdvancedSearch'.
>2. Review the current descriptions for the AdvancedSearchTypes and
> OpacAdvancedSearchTypes system preferences.
>3. Note that "..Shelving Location.." is used instead of "..Shelving
> location..".
>4. Apply the patch.
>5. Refresh the page.
>6. Sentence case is now used for "Shelving location" in the
> descriptions (as per coding guideline HTML4: Upper and lower cases
> in strings).
>7. Sign off.
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
>Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>---
> .../intranet-tmpl/prog/en/modules/admin/preferences/opac.pref | 2 +-
> .../prog/en/modules/admin/preferences/searching.pref | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>index 10ec57475b..23c73bfb51 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>@@ -883,7 +883,7 @@ OPAC:
> - pref: OpacAdvancedSearchTypes
> class: long
> - "fields (separate values with |). Tabs appear in the order listed. "
>- - "Currently supported values: Item types (itemtypes), Collection, (ccode) and Shelving Location (loc)."
>+ - "Currently supported values: Item types (itemtypes), Collection, (ccode) and Shelving location (loc)."
> Authentication:
> -
> - pref: OPACShibOnly
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref
>index ed02b37d74..5496b52636 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref
>@@ -100,7 +100,7 @@ Searching:
> - pref: AdvancedSearchTypes
> class: long
> - "fields (separate values with |). Tabs appear in the order listed. "
>- - "Currently supported values: Item types (itemtypes), Collection, (ccode) and Shelving Location (loc)."
>+ - "Currently supported values: Item types (itemtypes), Collection, (ccode) and Shelving location (loc)."
> -
> - Limit the languages listed in the advanced search drop-down to the
> - pref: AdvancedSearchLanguages
>-- 
>2.36.1

Actions: View | Diff | Splinter Review

Attachments on bug 30786: 135086 | 135111 | 135449