Attachment 135452 Details for Bug 28723 – Bug 28723: Fix holds table display when a biblio has no title

[patch] Bug 28723: Fix holds table display when a biblio has no title

Bug-28723-Fix-holds-table-display-when-a-biblio-ha.patch (text/plain), 1.35 KB, created by David Nind on 2022-05-30 23:00:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2022-05-30 23:00:09 UTC

Size: 1.35 KB

patch

obsolete

>From ab2685af9f8b8cc6aa358140e33ddab02a03f253 Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Tue, 20 Jul 2021 14:45:35 +0200
>Subject: [PATCH] Bug 28723: Fix holds table display when a biblio has no title
>
>Test plan:
>1. Create a biblio without title, then create an item for this biblio.
>2. Place a hold on it.
>3. Go to the patron detail page and click on the Holds tab
>4. Confirm that holds are correctly displayed
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/intranet-tmpl/prog/js/holds.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/holds.js b/koha-tmpl/intranet-tmpl/prog/js/holds.js
>index 44e110df43..c422cfaf8e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/holds.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/holds.js
>@@ -138,7 +138,7 @@ $(document).ready(function() {
>                             title = "<a href='/cgi-bin/koha/reserve/request.pl?biblionumber="
>                                   + oObj.biblionumber
>                                   + "'>"
>-                                  + oObj.title.escapeHtml();
>+                                  + (oObj.title ? oObj.title.escapeHtml() : __('No title'));
> 
>                             $.each(oObj.subtitle, function( index, value ) {
>                                 title += " " + value.escapeHtml();
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 28723: 122973 | 122975 | 135447 | 135452 | 135484 | 135485 | 135486