Bugzilla – Attachment 135467 Details for
Bug 30828
Remove unused variable in placerequest.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30828: Remove useless 'type' parameter in placerequest.pl
Bug-30828-Remove-useless-type-parameter-in-placere.patch (text/plain), 2.29 KB, created by
Jonathan Druart
on 2022-05-31 06:55:21 UTC
(
hide
)
Description:
Bug 30828: Remove useless 'type' parameter in placerequest.pl
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2022-05-31 06:55:21 UTC
Size:
2.29 KB
patch
obsolete
>From d50386ba68481c79e3e59fb483ea7f2b7b511ba7 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@iki.fi> >Date: Sat, 21 May 2022 19:23:32 +0000 >Subject: [PATCH] Bug 30828: Remove useless 'type' parameter in placerequest.pl > >To test: > 1) Grep for placerequest.pl in the source code and check that > request.tt is the only place where the type parameter is passed. > >Signed-off-by: David Nind <david@davidnind.com> > >JD amended patch: adjust commit title >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 2 -- > reserve/placerequest.pl | 3 +-- > 2 files changed, 1 insertion(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 59f215ebd2a..2e82d6fc77f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -441,8 +441,6 @@ > <form action="placerequest.pl" method="post" name="form" id="hold-request-form"> > > <input type="hidden" name="borrowernumber" value="[% patron.borrowernumber | html %]" /> >- <input type="hidden" name="type" value="str8" /> >- > [% FOREACH biblionumber IN biblionumbers %] > <input type="hidden" name="biblionumber" value="[% biblionumber | html %]"/> > [% END %] >diff --git a/reserve/placerequest.pl b/reserve/placerequest.pl >index 0a8d6dd64e6..7c8e454184c 100755 >--- a/reserve/placerequest.pl >+++ b/reserve/placerequest.pl >@@ -42,7 +42,6 @@ my $notes = $input->param('notes'); > my $branch = $input->param('pickup'); > my $startdate = $input->param('reserve_date') || ''; > my @rank = $input->multi_param('rank-request'); >-my $type = $input->param('type'); > my $title = $input->param('title'); > my $checkitem = $input->param('checkitem'); > my $expirationdate = $input->param('expiration_date'); >@@ -66,7 +65,7 @@ foreach my $bibnum (@biblionumbers) { > > my $found; > >-if ( $type eq 'str8' && $patron ) { >+if ( $patron ) { > > foreach my $biblionumber ( keys %bibinfos ) { > >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30828
:
135257
|
135283
| 135467