Attachment 135501 Details for Bug 26377 – Bug 26377: Show when loading the page if needed

[patch] Bug 26377: Show when loading the page if needed

Bug-26377-Show-when-loading-the-page-if-needed.patch (text/plain), 2.84 KB, created by Jonathan Druart on 2022-05-31 13:16:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2022-05-31 13:16:34 UTC

Size: 2.84 KB

patch

obsolete

>From a377725762ac692bba63d3f5b49d3069a654f6a0 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 31 May 2022 11:16:57 +0200
>Subject: [PATCH] Bug 26377: Show when loading the page if needed
>
>Prevent a blink
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> .../prog/en/modules/serials/subscription-add.tt           | 8 ++++++++
> koha-tmpl/intranet-tmpl/prog/js/subscription-add.js       | 4 ----
> 2 files changed, 8 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
>index c22a621ee76..fac2c17b700 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
>@@ -199,7 +199,11 @@ fieldset.rows table { clear: none; margin: 0; }
>                                         [% END %]
>                                     </select>
>                                 </li>
>+                                [% IF serialsadditems %]
>+                                <li class="use_items">
>+                                [% ELSE %]
>                                 <li class="use_items" style="display:none">
>+                                [% END %]
>                                     <label for="ccode">Collection:</label>
>                                     <select name="ccode" id="ccode">
>                                         <option value="">None</option>
>@@ -212,7 +216,11 @@ fieldset.rows table { clear: none; margin: 0; }
>                                         [% END %]
>                                     </select>
>                                 </li>
>+                                [% IF serialsadditems %]
>+                                <li class="use_items">
>+                                [% ELSE %]
>                                 <li class="use_items" style="display:none">
>+                                [% END %]
>                                     <label for="itemtype">Item type:</label>
>                                     <select name="itemtype" id="itemtype">
>                                         <option value=""></option>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/subscription-add.js b/koha-tmpl/intranet-tmpl/prog/js/subscription-add.js
>index 7d5445fce88..2d7ce39c567 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/subscription-add.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/subscription-add.js
>@@ -726,10 +726,6 @@ $(document).ready(function() {
>         });
>     });
> 
>-    if( $("#serialsadditems-yes").prop("checked") ){
>-        $(".use_items").show();
>-    }
>-
>     $("#serialsadditems-yes").on("change", function(){
>         if( $(this).prop("checked") ){
>             $(".use_items").show();
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 26377: 134968 | 135355 | 135455 | 135479 | 135480 | 135491 | 135492 | 135500 | 135501 | 135502