Attachment 135570 Details for Bug 30462 – B

[patch] B

Bug-30462-Delete-the-updateelasticindex-jobs-when-.patch (text/plain), 1.25 KB, created by Jonathan Druart on 2022-06-02 06:10:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2022-06-02 06:10:05 UTC

Size: 1.25 KB

patch

obsolete

>From 74f227c40b7d2d08d989f6d7f100a24e9754da7b Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 2 Jun 2022 08:04:20 +0200
>Subject: [PATCH] Bug 30462: Delete the update_elastic_index jobs when done
>
>One entry per reindexation will generate a lot of rows in this table and
>the UI will become unusable.
>We should either hide them by default or simply remove them from the DB.
>This patch implements the second option.
>
>Test plan:
>Edit a bibliographic record
>If you are fast enough you should see a "new" jobs in the
>background_jobs DB table
>When done/finished, the rows will be deleted from the DB
>---
> Koha/BackgroundJob/UpdateElasticIndex.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/BackgroundJob/UpdateElasticIndex.pm b/Koha/BackgroundJob/UpdateElasticIndex.pm
>index c3a77a43c16..e47c08c69bf 100644
>--- a/Koha/BackgroundJob/UpdateElasticIndex.pm
>+++ b/Koha/BackgroundJob/UpdateElasticIndex.pm
>@@ -80,8 +80,8 @@ sub process {
>         }
>     } else {
>         $self->step;
>-        # FIXME This is not correct if some record_ids have been skipped
>-        $report->{total_success} = scalar @record_ids;
>+        $self->delete;
>+        return;
>     }
> 
>     my $data = $self->decoded_data;
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 30462: 135570 | 135583 | 135749 | 135750 | 135938 | 136001 | 136002 | 136003 | 136004 | 140145 | 140146 | 140147 | 140148 | 140353 | 142860