Bugzilla – Attachment 135612 Details for
Bug 30891
SMS provider shows on staff side even if SMS::Send driver is not set to "Email"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30891: SMS provider shows on staff side even if SMS::Send driver is not set to "Email"
Bug-30891-SMS-provider-shows-on-staff-side-even-if.patch (text/plain), 2.03 KB, created by
Lucas Gass (lukeg)
on 2022-06-02 17:35:25 UTC
(
hide
)
Description:
Bug 30891: SMS provider shows on staff side even if SMS::Send driver is not set to "Email"
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2022-06-02 17:35:25 UTC
Size:
2.03 KB
patch
obsolete
>From 9d346883819cb47571bc3d71e883b368e0c54871 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 2 Jun 2022 10:23:08 -0400 >Subject: [PATCH] Bug 30891: SMS provider shows on staff side even if SMS::Send > driver is not set to "Email" > >It appears that in my original submission ( Bug 9021 ), >I hid the SMS provider selector unless the SMS::Send >driver was set to "Email", but only on the OPAC, >not on the staff interface! > >Test Plan: >1) Set SMSSendDriver to anything except "Email" >2) Note the SMS Provider pulldown shows in the patron editor >3) Apply this patch >4) Reload the page, SMS Provider id should now be gone >5) Set SMSSendDriver to "Email" >6) Reload the page, SMS Provider should now be shown > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >index e61ae4f688..867074bf7b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >@@ -1511,7 +1511,7 @@ legend:hover { > <input type="text" id="SMSnumber" name="SMSnumber" value="[% SMSnumber | html %]" /> > <span class="hint sms_number_help">Please enter numbers only. Prefix the number with + if including the country code.</span> > </p> >- [% UNLESS nosms_provider_id %] >+ [% IF SMSSendDriver == 'Email' && !nosms_provider_id %] > <p> > <label for="sms_provider_id">SMS provider:</label> > <select id="sms_provider_id" name="sms_provider_id"> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30891
:
135589
|
135612
|
135721
|
135722