Attachment 135649 Details for Bug 27272 – Bug 27272: already_reserved never set (was set before 14695)

[patch] Bug 27272: already_reserved never set (was set before 14695)

Bug-27272-alreadyreserved-never-set-was-set-before.patch (text/plain), 1.10 KB, created by Jonathan Druart on 2022-06-03 06:49:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2022-06-03 06:49:48 UTC

Size: 1.10 KB

patch

obsolete

>From 15a6cf9d968f1021c829982fe5172d25d1c60362 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 3 Jun 2022 07:32:35 +0200
>Subject: [PATCH] Bug 27272: already_reserved never set (was set before 14695)
>
>---
> opac/opac-reserve.pl | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl
>index cd71a6af293..2dfbed123a8 100755
>--- a/opac/opac-reserve.pl
>+++ b/opac/opac-reserve.pl
>@@ -563,10 +563,9 @@ foreach my $biblioNum (@biblionumbers) {
>         my $patron_unblessed = $patron->unblessed;
>         my $branch = GetReservesControlBranch( $itemInfo, $patron_unblessed );
> 
>-        my $policy_holdallowed = !$itemLoopIter->{already_reserved};
>         # items_any_available defined outside of the current loop,
>         # so we avoiding loop inside IsAvailableForItemLevelRequest:
>-        $policy_holdallowed &&=
>+        my $policy_holdallowed =
>             CanItemBeReserved( $patron, $item )->{status} eq 'OK' &&
>             IsAvailableForItemLevelRequest($item, $patron, undef, $items_any_available);
> 
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 27272: 128230 | 128231 | 135640 | 135641 | 135642 | 135643 | 135644 | 135645 | 135646 | 135647 | 135648 | 135649 | 135650 | 135651 | 135652 | 135653 | 135654 | 135655 | 135656 | 135657 | 135658 | 135659 | 137966 | 137967 | 137968 | 137969 | 137970 | 137971 | 137972 | 137973 | 137974 | 137975 | 137976 | 137977 | 137978 | 137979 | 137980 | 137981 | 137982 | 138109 | 138296 | 138297 | 138298 | 138303 | 138304 | 138305 | 138306 | 138307 | 138308 | 138437 | 138438 | 138439 | 138440 | 138441 | 138442 | 138553 | 138554 | 138555 | 138556 | 138557 | 138558 | 138559 | 138560 | 138561 | 138562 | 138563 | 138564 | 138565 | 138566 | 138567 | 138568 | 138569 | 138570 | 138571 | 138572 | 138573 | 138574 | 138575 | 138614 | 138615 | 138616 | 138617 | 138618 | 138619 | 138620 | 138621 | 138622 | 138623 | 138624 | 138625 | 138626 | 138627 | 138628 | 138629 | 138630 | 138631 | 138632 | 138633 | 138634 | 138635 | 138636 | 138714 | 138715 | 138716 | 138717 | 138718 | 138719 | 138720 | 138721 | 138722 | 138723 | 138724 | 138725 | 138726 | 138727 | 138728 | 138729 | 138730 | 138731 | 138732 | 138733 | 138734 | 138735 | 138736 | 138773 | 138774 | 138775 | 138776 | 138777 | 138778 | 138779 | 138780 | 138781 | 138782 | 138783 | 138784 | 138785 | 138786 | 138787 | 138788 | 138789 | 138790 | 138791 | 138792 | 138793 | 138794 | 138832 | 139928