Attachment 135719 Details for Bug 30868 – Bug 30868: (bug 29684 follow-up) Fix borrowernumber var in template

[patch] Bug 30868: (bug 29684 follow-up) Fix borrowernumber var in template

Bug-30868-bug-29684-follow-up-Fix-borrowernumber-v.patch (text/plain), 3.67 KB, created by Katrin Fischer on 2022-06-06 10:54:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2022-06-06 10:54:54 UTC

Size: 3.67 KB

patch

obsolete

>From 373b210192e3e9f8a5ca90a6ea0101f13ae45174 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 31 May 2022 08:23:30 +0200
>Subject: [PATCH] Bug 30868: (bug 29684 follow-up) Fix borrowernumber var in
> template
>
>borrower_data does not contain the borrowernumber, it is sent
>separately.
>
>Test plan:
>1. Edit a patron record (for example: Henry Acevedo).
>2. Note that the URL is http://127.0.0.1:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=19
>3. Change date of birth to yesterday.
>4. Save.
>5. Error message displayed above the Save and Cancel buttons:
>   The following fields are wrong. Please fix them.
>   - Patron's age is incorrect for their category. Ages allowed are 18-999.
>6. Note that the URL is now http://127.0.0.1:8081/cgi-bin/koha/members/memberentry.pl
>7. Fix date of birth (for example: change year to 2000).
>8. Select Save.
>=> Without this patch you get: "Patron not found. Return to search."
>=> With this patch applied the patron's data is saved
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>index e61ae4f688..5ea169e046 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>@@ -51,7 +51,7 @@ legend:hover {
>                 </li>
>                 [% IF (borrower_data.firstname || borrower_data.surname ) %]
>                     <li>
>-                        <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrower_data.borrowernumber | uri %]">
>+                        <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber | uri %]">
>                             [% INCLUDE 'patron-title.inc' %]
>                         </a>
>                     </li>
>@@ -229,7 +229,7 @@ legend:hover {
>                                 [% IF opadd %]
>                                     <a class="btn btn-default" href="/cgi-bin/koha/members/member.pl" class="toggler save_entryform">
>                                 [% ELSE %]
>-                                    <a class="btn btn-default" href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrower_data.borrowernumber | html %]">
>+                                    <a class="btn btn-default" href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber | html %]">
>                                 [% END %]
>                                     <i class="fa fa-times"></i> Cancel
>                                 </a>
>@@ -246,7 +246,7 @@ legend:hover {
>                             <input type="hidden" name="updtype" value="[% updtype | html %]" />
>                             <input type="hidden" name="destination" value="[% destination | html %]" />
>                             <input type="hidden" name="check_member" value="[% check_member | html %]" />
>-                            <input type="hidden" name="borrowernumber" value="[% borrower_data.borrowernumber | html UNLESS opduplicate %]" />
>+                            <input type="hidden" name="borrowernumber" value="[% borrowernumber | html UNLESS opduplicate %]" />
>                             <input type="hidden" name="nodouble"  value="[% nodouble | html UNLESS opduplicate %]" />
>                             <input type="hidden" name="csrf_token" value="[% csrf_token | html %]" />
>                             [% IF ( step ) %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30868: 135465 | 135466 | 135719