Attachment 135744 Details for Bug 29963 – Bug 29963: Do not prefill empty date fields with today's date

[patch] Bug 29963: Do not prefill empty date fields with today's date

Bug-29963-Do-not-prefill-empty-date-fields-with-to.patch (text/plain), 2.31 KB, created by Martin Renvoize (ashimema) on 2022-06-07 07:29:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2022-06-07 07:29:05 UTC

Size: 2.31 KB

patch

obsolete

>From 196b34c4d5a0d4c455a0660f3db79a1296bf97de Mon Sep 17 00:00:00 2001
>From: Petro Vashchuk <stalkernoid@gmail.com>
>Date: Fri, 3 Jun 2022 19:10:03 +0300
>Subject: [PATCH] Bug 29963: Do not prefill empty date fields with today's date
>
>Revert "Bug 29815: Pre-populate 'Date acquired' field when adding/editing items"
>commit bd197c64567fba6899f12e4897d786adf52384d8
>
>Items date fields in MARC framework with dateaccessioned.pl assigned as
>plugin automatically prefilled by it with today's date if empty on page
>load.
>
>This becomes big problem because it silently changes empty date fields
>in single item edit form with today's date. This drastically degrades
>UX because user won't noitce that fields were filled.
>
>Also, even when user aware about this problem, user is forced to clean
>the field manually each time they edit items with empty fields.
>
>Also in item batch edit tool the probability heavily increases to make
>mistake and leave those fields prefilled on mass.
>
>To reproduce problem with single item edit:
>1. Edit single item that doesn't have a date set in any of the date
>fields where dateaccessioned.pl in MARC framework assigned as plugin,
>see that the field got prefilled with today's date.
>2. Save the item. See that it overwrote the previously empty date.
>3. Apply the patch.
>4. Edit single item again, and ensure that the empty date fields don't
>get overwriten like it happened previously.
>
>To reproduce problem with bath edit:
>1. Edit items in batch for any biblio, see that the date fields where
>dateaccessioned.pl in MARC framework assigned as plugin is automatically
> set to current day's date.
>2. Apply the patch.
>3. Check the fields again, they should be empty after that.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> cataloguing/value_builder/dateaccessioned.pl | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/cataloguing/value_builder/dateaccessioned.pl b/cataloguing/value_builder/dateaccessioned.pl
>index 2f027c8e9a..d1377a2bf6 100755
>--- a/cataloguing/value_builder/dateaccessioned.pl
>+++ b/cataloguing/value_builder/dateaccessioned.pl
>@@ -41,8 +41,6 @@ my $builder = sub {
>         altInputClass: "input_marceditor flatpickr-input",
>         dateFormat: "Y-m-d"
>     });
>-    /* Set current date on page load */
>-    set_to_today($function_name.id);
> });
> 
> function Focus$function_name(event) {
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29963: 135581 | 135582 | 135674 | 135683 | 135684 | 135744 | 135745 | 135746 | 135755 | 136153