Bugzilla – Attachment 135789 Details for
Bug 30914
cleanup_database.pl --transfers --old-reserves --confirm does not work
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30914: (24153 follow-up) Fix cleanup_database.pl --transfers --old-reserves
Bug-30914-24153-follow-up-Fix-cleanupdatabasepl---.patch (text/plain), 1.55 KB, created by
Fridolin Somers
on 2022-06-08 07:04:57 UTC
(
hide
)
Description:
Bug 30914: (24153 follow-up) Fix cleanup_database.pl --transfers --old-reserves
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2022-06-08 07:04:57 UTC
Size:
1.55 KB
patch
obsolete
>From 9aa20beb2b52a85d9ac16f915178aafcabe0c2fa Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 7 Jun 2022 14:11:06 +0200 >Subject: [PATCH] Bug 30914: (24153 follow-up) Fix cleanup_database.pl > --transfers --old-reserves > >Silly mistake, 'delete if verbose' must be 'delete if confirm' > >Test plan: >Try the cleanup_database.pl script to delete transfers and old issues. >Using --transfers --old-reserves and the --confirm flag the entries must be >removed > >Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> >--- > misc/cronjobs/cleanup_database.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/misc/cronjobs/cleanup_database.pl b/misc/cronjobs/cleanup_database.pl >index 56b7a7d7c4..74505cf067 100755 >--- a/misc/cronjobs/cleanup_database.pl >+++ b/misc/cronjobs/cleanup_database.pl >@@ -609,7 +609,7 @@ if ($pOldReserves) { > print "Purging old reserves older than $pOldReserves days.\n" if $verbose; > my $old_reserves = Koha::Old::Holds->filter_by_last_update( { days => $pOldReserves } ); > my $count = $old_reserves->count; >- $old_reserves->delete if $verbose; >+ $old_reserves->delete if $confirm; > if ($verbose) { > say $confirm > ? sprintf "Done with purging %d old reserves.", $count >@@ -626,7 +626,7 @@ if ($pTransfers) { > } > ); > my $count = $transfers->count; >- $transfers->delete if $verbose; >+ $transfers->delete if $confirm; > if ($verbose) { > say $confirm > ? sprintf "Done with purging %d transfers.", $count >-- >2.35.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30914
:
135756
|
135789
|
135969