Attachment 135797 Details for Bug 29697 – Bug 29697: Special case - opac not needed

[patch] Bug 29697: Special case - opac not needed

Bug-29697-Special-case---opac-not-needed.patch (text/plain), 1.42 KB, created by Jonathan Druart on 2022-06-08 12:33:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2022-06-08 12:33:40 UTC

Size: 1.42 KB

patch

obsolete

>From 66a6e3d79579844b02e2ebb8bce0ab3d71c2b09d Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 21 Jan 2022 11:04:23 +0100
>Subject: [PATCH] Bug 29697: Special case - opac not needed
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> opac/opac-detail.pl | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
>diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl
>index f6b713542d4..f132692655f 100755
>--- a/opac/opac-detail.pl
>+++ b/opac/opac-detail.pl
>@@ -38,7 +38,6 @@ use C4::Output qw( parametrized_url output_html_with_http_headers );
> use C4::Biblio qw(
>     CountItemsIssued
>     GetBiblioData
>-    GetMarcBiblio
>     GetMarcControlnumber
>     GetMarcISBN
>     GetMarcISSN
>@@ -113,15 +112,13 @@ if( $specific_item ) {
> my @hiddenitems;
> my $patron = Koha::Patrons->find( $borrowernumber );
> 
>-my $record = GetMarcBiblio({
>-    biblionumber => $biblionumber,
>-    opac         => 1 });
>-if ( ! $record ) {
>+my $biblio = Koha::Biblios->find( $biblionumber );
>+my $record = $biblio ? $biblio->metadata->record : undef;
>+unless ( $biblio && $record ) {
>     print $query->redirect("/cgi-bin/koha/errors/404.pl"); # escape early
>     exit;
> }
> 
>-my $biblio = Koha::Biblios->find( $biblionumber );
> unless ( $patron and $patron->category->override_hidden_items ) {
>     # only skip this check if there's a logged in user
>     # and its category overrides OpacHiddenItems
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 29697: 129757 | 129758 | 129759 | 129760 | 129761 | 131868 | 131869 | 131870 | 131871 | 131872 | 131873 | 134066 | 134067 | 134068 | 134069 | 134070 | 134071 | 135574 | 135575 | 135576 | 135577 | 135578 | 135579 | 135580 | 135662 | 135663 | 135664 | 135665 | 135666 | 135667 | 135668 | 135669 | 135670 | 135671 | 135672 | 135673 | 135797 | 135798 | 135799 | 135800 | 135801 | 135802 | 135978 | 135979 | 135980 | 135981 | 135982 | 137835 | 137836 | 137837 | 137838 | 137839 | 137840 | 137894 | 137918 | 137919 | 137920 | 137921 | 137922 | 137923 | 137924 | 137948 | 138057 | 138076 | 138077 | 138078 | 138079 | 138080 | 138081 | 138089 | 138090 | 138804 | 139127 | 140007 | 140008