Attachment 135809 Details for Bug 11889 – Bug 11889: (follow-up) Remove share if you are the new owner

[patch] Bug 11889: (follow-up) Remove share if you are the new owner

Bug-11889-follow-up-Remove-share-if-you-are-the-ne.patch (text/plain), 1.17 KB, created by Marcel de Rooy on 2022-06-08 13:47:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2022-06-08 13:47:34 UTC

Size: 1.17 KB

patch

obsolete

>From 741f80075e445545b099c3c430931c515db6f08e Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Thu, 16 Feb 2017 10:04:27 +0100
>Subject: [PATCH] Bug 11889: (follow-up) Remove share if you are the new owner
>MIME-Version: 1.0
>Content-Type: text/plain; charset=utf-8
>Content-Transfer-Encoding: 8bit
>Content-Type: text/plain; charset=utf-8
>
>This will probably be exceptional. But if the staff member already had
>a share for a private list of the patron he deletes now, he will be
>the new owner and we should remove the share record.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Signed-off-by: CÃ©dric Vita <cedric.vita@dracenie.com>
>---
> Koha/Patron.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/Koha/Patron.pm b/Koha/Patron.pm
>index 2a7280aa01..a642b0dfaf 100644
>--- a/Koha/Patron.pm
>+++ b/Koha/Patron.pm
>@@ -400,6 +400,8 @@ sub delete {
>                 }
>                 foreach my $slist ( @sharedlists ) {
>                     $slist->set({ owner => $usernumber })->store;
>+                    # if staff member had a share, remove it
>+                    $slist->remove_share( $usernumber );
>                 }
>             }
> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 11889: 25972 | 60224 | 60306 | 60307 | 60308 | 60481 | 61319 | 61320 | 61321 | 61322 | 61451 | 61452 | 61453 | 61454 | 108244 | 108245 | 108246 | 108247 | 135808 | 135809 | 135810 | 135811 | 135812 | 135813 | 135814 | 135815 | 135816 | 135817 | 135818 | 135819 | 135820 | 135821 | 135857 | 135858 | 135859 | 135860 | 135861 | 135862 | 135863 | 135864 | 135865 | 135866 | 135867 | 135868 | 135869 | 135870 | 135871 | 135872 | 135873 | 135874 | 135875 | 135876 | 135891 | 135892 | 135893 | 135894 | 135895 | 135896 | 135897 | 135898 | 135899 | 135900 | 135901