Attachment 135824 Details for Bug 30399 – Bug 30399: Make Patron.t pass even if mandatory attributes exist

[patch] Bug 30399: Make Patron.t pass even if mandatory attributes exist

Bug-30399-Make-Patront-pass-even-if-mandatory-attr.patch (text/plain), 2.32 KB, created by David Nind on 2022-06-08 16:35:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2022-06-08 16:35:24 UTC

Size: 2.32 KB

patch

obsolete

>From b3131d71e1f09ea363a5d61e0f320126469c8b55 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 8 Jun 2022 11:39:43 +0200
>Subject: [PATCH] Bug 30399: Make Patron.t pass even if mandatory attributes
> exist
>
>t/db_dependent/Koha/Patron.t is failing if mandatory attributes already
>exist in the DB. We can make it pass easily by deleting all the
>attributes before we run the tests.
>
>Test plan:
>  prove t/db_dependent/Koha/Patron.t
>must return green even if one mandatory patron attribute exists.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> t/db_dependent/Koha/Patron.t | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/t/db_dependent/Koha/Patron.t b/t/db_dependent/Koha/Patron.t
>index c27dfc405f..37214105e5 100755
>--- a/t/db_dependent/Koha/Patron.t
>+++ b/t/db_dependent/Koha/Patron.t
>@@ -377,6 +377,8 @@ subtest 'extended_attributes' => sub {
>     my $schema = Koha::Database->new->schema;
>     $schema->storage->txn_begin;
> 
>+    Koha::Patron::Attribute::Types->search->delete;
>+
>     my $patron_1 = $builder->build_object({class=> 'Koha::Patrons'});
>     my $patron_2 = $builder->build_object({class=> 'Koha::Patrons'});
> 
>@@ -507,6 +509,7 @@ subtest 'extended_attributes' => sub {
>         plan tests => 3;
> 
>         $schema->storage->txn_begin;
>+        Koha::Patron::Attribute::Types->search->delete;
> 
>         my $patron = $builder->build_object({ class => 'Koha::Patrons' });
>         my $attribute_type = $builder->build_object(
>@@ -541,6 +544,7 @@ subtest 'extended_attributes' => sub {
>         plan tests => 5;
> 
>         $schema->storage->txn_begin;
>+        Koha::Patron::Attribute::Types->search->delete;
> 
>         my $patron_1 = $builder->build_object({ class => 'Koha::Patrons' });
>         my $patron_2 = $builder->build_object({ class => 'Koha::Patrons' });
>@@ -593,6 +597,7 @@ subtest 'extended_attributes' => sub {
>         plan tests => 3;
> 
>         $schema->storage->txn_begin;
>+        Koha::Patron::Attribute::Types->search->delete;
> 
>         my $patron = $builder->build_object({ class => 'Koha::Patrons' });
> 
>@@ -637,6 +642,7 @@ subtest 'extended_attributes' => sub {
>         plan tests => 5;
> 
>         $schema->storage->txn_begin;
>+        Koha::Patron::Attribute::Types->search->delete;
> 
>         my $patron = $builder->build_object({ class => 'Koha::Patrons' });
> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30399: 135791 | 135824 | 135968