Attachment 135885 Details for Bug 30907 – Bug 30907: Fix incorrect uses of Koha::Recall->item_level_recall

[patch] Bug 30907: Fix incorrect uses of Koha::Recall->item_level_recall

Bug-30907-Fix-incorrect-uses-of-KohaRecall-itemlev.patch (text/plain), 2.49 KB, created by Martin Renvoize (ashimema) on 2022-06-09 14:19:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2022-06-09 14:19:32 UTC

Size: 2.49 KB

patch

obsolete

>From f59bf85b214835cc0de72d1977a58bfb8fb32009 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Thu, 9 Jun 2022 10:22:16 -0300
>Subject: [PATCH] Bug 30907: Fix incorrect uses of
> Koha::Recall->item_level_recall
>
>This attribute name was changed to *item_level* but this two remaining
>places kept calling it with the old name.
>
>To test, verify things don't explode when looking at checkouts with
>recalls and also in the log viewer.
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt | 2 +-
> svc/checkouts                                            | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt
>index a5881d04a5..9cb00c2ca6 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt
>@@ -372,7 +372,7 @@
>                                                 [% loopro.object | html %]
>                                             [% END %]
>                                         [% ELSIF ( loopro.module == 'RECALLS' ) %]
>-                                            [% IF loopro.recall.item_level_recall %]
>+                                            [% IF loopro.recall.item_level %]
>                                                 Item-level recall on <a href="/cgi-bin/koha/catalogue/moredetail.pl?item=[% loopro.recall.itemnumber | uri %]&amp;biblionumber=[% loopro.recall.biblionumber | uri %]&amp;bi=[% loopro.recall.item.biblioitemnumber | uri %]">item</a>
>                                             [% ELSE %]
>                                                 Biblio-level recall on <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% loopro.recall.biblionumber | uri %]">biblio</a>
>diff --git a/svc/checkouts b/svc/checkouts
>index 7c28c2703d..c6a3e6c6f3 100755
>--- a/svc/checkouts
>+++ b/svc/checkouts
>@@ -220,7 +220,7 @@ while ( my $c = $sth->fetchrow_hashref() ) {
>         my $recall = undef;
>         $recall = $item->check_recalls if $item->can_be_waiting_recall;
>         if ( defined $recall ) {
>-            if ( $recall->item_level_recall ) {
>+            if ( $recall->item_level ) {
>                 if ( $recall->itemnumber == $c->{itemnumber} ) {
>                     # item-level recall on this item
>                     $recalled = 1;
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 30907: 135882 | 135885