Attachment 135900 Details for Bug 11889 – Bug 11889: (follow-up) We did not need get_shared_shelves after all

[patch] Bug 11889: (follow-up) We did not need get_shared_shelves after all

Bug-11889-follow-up-We-did-not-need-getsharedshelv.patch (text/plain), 2.00 KB, created by Martin Renvoize (ashimema) on 2022-06-09 14:58:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2022-06-09 14:58:37 UTC

Size: 2.00 KB

patch

obsolete

>From 69adeeedb33380b77ff7ac853551d10bc88299a3 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Thu, 9 Jun 2022 09:12:18 +0000
>Subject: [PATCH] Bug 11889: (follow-up) We did not need get_shared_shelves
> after all
>
>Test plan:
>Run t/db_dependent/Virtualshelves.t
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> Koha/Virtualshelves.pm          | 17 -----------------
> t/db_dependent/Virtualshelves.t |  4 ++--
> 2 files changed, 2 insertions(+), 19 deletions(-)
>
>diff --git a/Koha/Virtualshelves.pm b/Koha/Virtualshelves.pm
>index 53a5ec5b5c..8b40596167 100644
>--- a/Koha/Virtualshelves.pm
>+++ b/Koha/Virtualshelves.pm
>@@ -191,23 +191,6 @@ sub get_shelves_containing_record {
>     );
> }
> 
>-=head3 get_shared_shelves
>-
>-=cut
>-
>-sub get_shared_shelves {
>-    my ( $self, $params ) = @_;
>-    my $borrowernumber = $params->{borrowernumber} || 0;
>-
>-    $self->search(
>-        {
>-            'me.owner' => $borrowernumber,
>-            'me.shelfnumber' => { -ident => 'virtualshelfshares.shelfnumber' }
>-        },
>-        { prefetch => 'virtualshelfshares' }
>-    );
>-}
>-
> =head3 _type
> 
> =cut
>diff --git a/t/db_dependent/Virtualshelves.t b/t/db_dependent/Virtualshelves.t
>index 1de7ddc580..9cb32d98d3 100755
>--- a/t/db_dependent/Virtualshelves.t
>+++ b/t/db_dependent/Virtualshelves.t
>@@ -497,8 +497,8 @@ subtest 'Get shelves' => sub {
>     is( $public_shelves->count, 2, 'get_public_shelves should return all public shelves, no matter who is the owner' );
> 
>     my $shared_shelf = eval { $shelf_to_share->share("valid key") };
>-    my $shared_shelves = Koha::Virtualshelves->get_shared_shelves({ borrowernumber => $patron1->{borrowernumber} });
>-    is( $shared_shelves->count, 1, 'get_shared_shelves should return shared shelves' );
>+    my $shared_shelves = Koha::Virtualshelfshares->search({ borrowernumber => $patron1->{borrowernumber} });
>+    is( $shared_shelves->count, 1, 'Found the share for patron1' );
> 
>     teardown();
> };
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 11889: 25972 | 60224 | 60306 | 60307 | 60308 | 60481 | 61319 | 61320 | 61321 | 61322 | 61451 | 61452 | 61453 | 61454 | 108244 | 108245 | 108246 | 108247 | 135808 | 135809 | 135810 | 135811 | 135812 | 135813 | 135814 | 135815 | 135816 | 135817 | 135818 | 135819 | 135820 | 135821 | 135857 | 135858 | 135859 | 135860 | 135861 | 135862 | 135863 | 135864 | 135865 | 135866 | 135867 | 135868 | 135869 | 135870 | 135871 | 135872 | 135873 | 135874 | 135875 | 135876 | 135891 | 135892 | 135893 | 135894 | 135895 | 135896 | 135897 | 135898 | 135899 | 135900 | 135901