Attachment 135986 Details for Bug 29897 – Bug 29897: Display author's identifiers

[patch] Bug 29897: Display author's identifiers

Bug-29897-Display-authors-identifiers.patch (text/plain), 11.34 KB, created by Jonathan Druart on 2022-06-13 08:24:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2022-06-13 08:24:04 UTC

Size: 11.34 KB

patch

obsolete

>From f4ceb3758d32b228930fb88685d299418c0d764e Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 17 Jan 2022 17:59:21 +0100
>Subject: [PATCH] Bug 29897: Display author's identifiers
>
>This new enhancement add the capability to list the different
>identifiers of authors. It is helpful for research publications for
>instance.
>
>This patch will add a new "Author identifiers" tab on the detail page
>(OPAC) of a bibliographic record, with the list of the authors and their
>identifiers.
>On the detail page of the authority record, the same identifier list
>will be displayed.
>
>Test plan:
>Create some authority with
>024
>  $a source
>  $2 number
>  $6 link to the source
>With the pref turned ON you will be able to see the new information.
>
>Sponsored-by: Orex Digital
>
>Signed-off-by: Orex Digital <info@orex.es>
>---
> Koha/Authority.pm                             | 30 ++++++++++++
> .../bootstrap/en/modules/opac-auth-detail.tt  | 29 +++++++++++-
> .../bootstrap/en/modules/opac-detail.tt       | 32 +++++++++++++
> opac/opac-authoritiesdetail.pl                |  6 +++
> opac/opac-detail.pl                           | 18 +++++++
> t/db_dependent/Koha/Authorities.t             | 47 ++++++++++++++++++-
> 6 files changed, 160 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/Authority.pm b/Koha/Authority.pm
>index cec6c662f45..0a6d30c6166 100644
>--- a/Koha/Authority.pm
>+++ b/Koha/Authority.pm
>@@ -114,6 +114,36 @@ sub controlled_indicators {
>     });
> }
> 
>+=head3 get_identifiers
>+
>+    my $identifiers = $author->get_identifiers;
>+
>+Return a list of identifiers of the authors which are in 024$2$a
>+
>+=cut
>+
>+sub get_identifiers {
>+    my ( $self, $params ) = @_;
>+
>+    my $flavour =
>+      C4::Context->preference('marcflavour') eq 'UNIMARC'
>+      ? 'UNIMARCAUTH'
>+      : 'MARC21';
>+    my $record =
>+      MARC::Record->new_from_xml( $self->marcxml, 'UTF-8', $flavour );
>+
>+    my @identifiers;
>+    for my $field ( $record->field('024') ) {
>+        my $sf_2 = $field->subfield('2');
>+        my $sf_a = $field->subfield('a');
>+        my $sf_6 = $field->subfield('6');
>+        next unless $sf_2 && $sf_a;
>+        push @identifiers, {source => $sf_2, number => $sf_a, linkage => $sf_6};
>+    }
>+
>+    return \@identifiers;
>+}
>+
> =head2 Class Methods
> 
> =head3 type
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt
>index 6ad74133212..7b6cd194c8c 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt
>@@ -43,7 +43,13 @@
>                             [% INCLUDE 'navigation.inc' %]
>                         </div>
>                     </div>
>-                    <div class="col-lg-10 order-first order-md-first order-lg-2">
>+                    [% IF Koha.Preference( 'OPACAuthorIdentifiers' ) && author_identifiers.size %]
>+                        <div class="col-lg-5 order-first order-md-first order-lg-2">
>+                    [% ELSE %]
>+                        <div class="col-lg-10 order-first order-md-first order-lg-2">
>+                    [% END %]
>+                [% ELSIF Koha.Preference( 'OPACAuthorIdentifiers' ) && author_identifiers.size %]
>+                    <div class="col-lg-6 order-first order-md-first order-lg-2">
>                 [% ELSE %]
>                     <div class="col order-first order-md-first order-lg-2">
>                 [% END %]
>@@ -166,6 +172,27 @@
>                         </div>
>                     </div> 
>                 </div> 
>+                [% IF Koha.Preference( 'OPACAuthorIdentifiers' ) && author_identifiers.size %]
>+                    [% IF ( OpacNav || OpacNavBottom ) %]
>+                        <div class="col-lg-5 order-lg-3">
>+                    [% ELSE %]
>+                        <div class="col-lg-6 order-lg-3">
>+                    [% END %]
>+                        <div class="author_identifier">
>+                            <span>Identifiers</span>
>+                            <ul>
>+                            [% FOR identifier IN author_identifiers %]
>+                                <li>
>+                                [% SWITCH identifier.source.lower %]
>+                                [% CASE 'orcid' %]ORCID: <a href="https://orcid.org/[% identifier.number | url %]">[% identifier.number | html %]</a>
>+                                [% CASE %][% identifier.source | html %]: [% identifier.number | html %]
>+                                [% END %]
>+                                </li>
>+                            [% END %]
>+                            </ul>
>+                        </div>
>+                    </div>
>+                [% END %]
>             </div> 
>         </div> 
>     </div> 
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>index a39cd0a0c0a..5e9c76d2a8d 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>@@ -469,6 +469,10 @@
>                             [% IF ( defaulttab == 'media' ) %]<li id="tab_html5media" class="ui-tabs-active">[% ELSE %]<li id="tab_html5media">[% END %]<a href="#html5media">Play media</a></li>
>                         [% END %]
> 
>+                        [% IF Koha.Preference( 'OPACAuthorIdentifiers' ) && author_identifiers.size %]
>+                            <li id="tab_author_identifiers"><a href="#author_identifiers">Author identifiers</a></li>
>+                        [% END %]
>+
>                     </ul>
> 
>                     [% IF ( serialcollection ) %]
>@@ -927,6 +931,34 @@
>                             </div>
>                         [% END # / IF OPACLocalCoverImages && localimages.size %]
> 
>+                        [% IF Koha.Preference( 'OPACAuthorIdentifiers' ) && author_identifiers.size %]
>+                            <div id="author_identifiers">
>+                                [% FOR author IN author_identifiers %]
>+                                    <div class="author_identifier">
>+                                        <span class="author_name"><a href="/cgi-bin/koha/opac-authoritiesdetail.pl?authid=[% author.authid | uri %]">[% author.name | html %]</a></span>
>+                                        <ul>
>+                                        [% FOR identifier IN author.identifiers %]
>+                                            <li>
>+                                            [% SWITCH identifier.source.lower %]
>+                                            [% CASE 'orcid' %]ORCID:
>+                                            [% CASE 'scopus' %]ScopusID:
>+                                            [% CASE 'loop' %]loop:
>+                                            [% CASE 'rid' %]Publons:
>+                                            [% CASE %][% identifier.source | html %]:
>+                                            [% END %]
>+                                            [% IF identifier.linkage %]
>+                                                <a href="[% identifier.linkage | uri %]">[% identifier.number | html %]</a>
>+                                            [% ELSE %]
>+                                                [% identifier.number | html %]
>+                                            [% END %]
>+                                            </li>
>+                                        [% END %]
>+                                        </ul>
>+                                    </div>
>+                                [% END %]
>+                            </div>
>+                        [% END %]
>+
>                 </div> 
> 
>                 [% IF ( NovelistSelectProfile && NovelistSelectView == 'below' && ( normalized_isbn || normalized_upc ) ) %]
>diff --git a/opac/opac-authoritiesdetail.pl b/opac/opac-authoritiesdetail.pl
>index ed0a1c70144..e6d41f7bd59 100755
>--- a/opac/opac-authoritiesdetail.pl
>+++ b/opac/opac-authoritiesdetail.pl
>@@ -168,6 +168,12 @@ if ($show_marc) {
> } else {
>     my $summary = BuildSummary($record, $authid, $authtypecode);
>     $template->{VARS}->{'summary'} = $summary;
>+
>+    if ( C4::Context->preference('OPACAuthorIdentifiers') ) {
>+        my $authority = Koha::Authorities->find($authid);
>+        my $identifiers = $authority->get_identifiers;
>+        $template->param( author_identifiers => $identifiers );
>+    }
> }
> 
> output_html_with_http_headers $query, $cookie, $template->output;
>diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl
>index 000eac3a513..b710d0a8856 100755
>--- a/opac/opac-detail.pl
>+++ b/opac/opac-detail.pl
>@@ -1249,4 +1249,22 @@ $template->param(
>     'OpacLocationBranchToDisplay' => C4::Context->preference('OpacLocationBranchToDisplay'),
> );
> 
>+if ( C4::Context->preference('OPACAuthorIdentifiers') ) {
>+    my @author_identifiers;
>+    for my $author ( @{ $biblio->get_marc_authors } ) {
>+        my $authid    = $author->{authoritylink};
>+        my $authority = Koha::Authorities->find($authid);
>+        next unless $authority;
>+        my $identifiers = $authority->get_identifiers;
>+        next unless $identifiers && @$identifiers;
>+        my ($name) =
>+          map  { $_->{value} }
>+          grep { $_->{code} eq 'a' ? $_ : () }
>+          @{ $author->{MARCAUTHOR_SUBFIELDS_LOOP} };
>+        push @author_identifiers,
>+          { authid => $authid, name => $name, identifiers => $identifiers };
>+    }
>+    $template->param( author_identifiers => \@author_identifiers );
>+}
>+
> output_html_with_http_headers $query, $cookie, $template->output;
>diff --git a/t/db_dependent/Koha/Authorities.t b/t/db_dependent/Koha/Authorities.t
>index 04ad663e28f..a9c507df837 100755
>--- a/t/db_dependent/Koha/Authorities.t
>+++ b/t/db_dependent/Koha/Authorities.t
>@@ -19,7 +19,7 @@
> 
> use Modern::Perl;
> 
>-use Test::More tests => 7;
>+use Test::More tests => 8;
> use MARC::Field;
> use MARC::File::XML;
> use MARC::Record;
>@@ -242,4 +242,49 @@ sub few_marc_records {
>     return [ $marc ];
> }
> 
>+subtest 'get_identifiers' => sub {
>+    plan tests => 1;
>+
>+    t::lib::Mocks::mock_preference( 'marcflavour', 'MARC21' );
>+    my $record = MARC::Record->new();
>+    $record->add_fields(
>+        [
>+            '100', ' ', ' ',
>+            a => 'Lastname, Firstname',
>+            b => 'b',
>+            c => 'c',
>+            i => 'i'
>+        ],
>+        [
>+            '024', '', '',
>+            a => '0000-0002-1234-5678',
>+            2 => 'orcid',
>+            6 => 'https://orcid.org/0000-0002-1234-5678'
>+        ],
>+        [
>+            '024', '', '',
>+            a => '01234567890',
>+            2 => 'scopus',
>+            6 => 'https://www.scopus.com/authid/detail.uri?authorId=01234567890'
>+        ],
>+    );
>+    my $authid = C4::AuthoritiesMarc::AddAuthority($record, undef, 'PERSO_NAME');
>+    my $authority = Koha::Authorities->find($authid);
>+    is_deeply(
>+        $authority->get_identifiers,
>+        [
>+            {
>+                source  => 'orcid',
>+                number  => '0000-0002-1234-5678',
>+                linkage => 'https://orcid.org/0000-0002-1234-5678'
>+            },
>+            {
>+                source => 'scopus',
>+                number => '01234567890',
>+                linkage => 'https://www.scopus.com/authid/detail.uri?authorId=01234567890'
>+            }
>+        ]
>+    );
>+};
>+
> $schema->storage->txn_rollback;
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 29897: 129816 | 129817 | 129818 | 129819 | 132961 | 132962 | 132963 | 132964 | 133081 | 133113 | 133114 | 133115 | 133116 | 133117 | 134459 | 134460 | 134461 | 134462 | 134463 | 134464 | 135983 | 135984 | 135985 | 135986 | 135987 | 135988 | 135989 | 135990 | 135991 | 135992 | 135993 | 138249 | 138250 | 138251 | 138252 | 138253 | 138254 | 138255 | 138256 | 138257 | 138258 | 138259 | 138260 | 138371 | 138372 | 138425 | 138426 | 138427 | 138428 | 138429 | 138430 | 138431 | 138432 | 138433 | 138434 | 138435 | 138486 | 138487 | 138490 | 138501 | 138664 | 138665 | 138666 | 138667 | 138668 | 138669 | 138670 | 138671 | 138672 | 138673 | 138674 | 138675 | 138676 | 138677 | 138678 | 138679